Bug 265173 - sysutils/py-salt: add rc variables
Summary: sysutils/py-salt: add rc variables
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Kirill Ponomarev
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-07-12 14:55 UTC by Trix Farrar
Modified: 2022-07-13 06:24 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (krion)


Attachments
py-salt-pidfile.patch (2.02 KB, patch)
2022-07-12 14:55 UTC, Trix Farrar
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Trix Farrar 2022-07-12 14:55:55 UTC
Created attachment 235220 [details]
py-salt-pidfile.patch

It appears that the pidfile: setting in master and minion configs is ignored by salt-master and salt-minion, respectively.  This patch adds a "--pid-file=${pidfile}" parameter to each of the command_args variable.

Also adds a salt_master_configdir and salt_minion_configdir variable that can base used to allow the required_files variables to be configured via sysrc(1).
Comment 1 commit-hook freebsd_committer freebsd_triage 2022-07-13 06:23:52 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=be1ee3ce8ccf59212635c985966c49ed334d1b71

commit be1ee3ce8ccf59212635c985966c49ed334d1b71
Author:     Kirill Ponomarev <krion@FreeBSD.org>
AuthorDate: 2022-07-13 06:21:12 +0000
Commit:     Kirill Ponomarev <krion@FreeBSD.org>
CommitDate: 2022-07-13 06:21:12 +0000

    sysutils/py-salt: Respect pid-file parameter and set salt_master_configdir/salt_minion_configdir variables

    PR:             265173
    Reported by:    trix@basement.net

 sysutils/py-salt/Makefile             | 1 +
 sysutils/py-salt/files/salt_master.in | 5 +++--
 sysutils/py-salt/files/salt_minion.in | 5 +++--
 3 files changed, 7 insertions(+), 4 deletions(-)
Comment 2 commit-hook freebsd_committer freebsd_triage 2022-07-13 06:23:53 UTC
A commit in branch 2022Q3 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=91d16fcee9492d841b65c03223f730c80c44d03e

commit 91d16fcee9492d841b65c03223f730c80c44d03e
Author:     Kirill Ponomarev <krion@FreeBSD.org>
AuthorDate: 2022-07-13 06:21:12 +0000
Commit:     Kirill Ponomarev <krion@FreeBSD.org>
CommitDate: 2022-07-13 06:23:21 +0000

    sysutils/py-salt: Respect pid-file parameter and set salt_master_configdir/salt_minion_configdir variables

    PR:             265173
    Reported by:    trix@basement.net

    (cherry picked from commit be1ee3ce8ccf59212635c985966c49ed334d1b71)

 sysutils/py-salt/Makefile             | 1 +
 sysutils/py-salt/files/salt_master.in | 5 +++--
 sysutils/py-salt/files/salt_minion.in | 5 +++--
 3 files changed, 7 insertions(+), 4 deletions(-)