Created attachment 235327 [details] v1 Bugfixes: Fixed certain albums not added to playlist in correct track order from search for Tidal and QObuz. Fixed songs not added to playlist in numeric order when added from file view with right click. Fixed "Stop after this track" graying out next track in dynamic mode. Fixed a gstreamer caps leak when transcoding songs. Fixed errors in translation files. Enhancements: Add songs to the collection even when they have invalid ctime or mtime. Made ListenBrainz scrobbler respect "Prefer album artist" option. Send track duration, number, player name and version when scrobbling to ListenBrainz.
Hi, ====> Running Q/A tests (stage-qa) Error: /usr/local/bin/strawberry is linked to /usr/local/lib/libiconv.so.2 from converters/libiconv but it is not declared as a dependency Warning: you need USES+=iconv, USES+=iconv:wchar_t, or USES+=iconv:translit depending on needs
(...) and set maintainer-approval flag to '+' in patch (details).
(In reply to Nuno Teixeira from comment #1) Also, the iconv USES is there, I've tried all the other options and none of them seems to work. This is happening since many of versions ago.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=a320aae1392f4ffd0bff6c73eb36eb4f7db1b26a commit a320aae1392f4ffd0bff6c73eb36eb4f7db1b26a Author: Daniel Menelkir <dmenelkir@gmail.com> AuthorDate: 2022-07-18 11:16:15 +0000 Commit: Nuno Teixeira <eduardo@FreeBSD.org> CommitDate: 2022-07-18 11:17:22 +0000 audio/strawberry: Update to 1.0.6 ChangeLog: https://github.com/strawberrymusicplayer/strawberry/blob/master/Changelog PR: 265290 audio/strawberry/Makefile | 2 +- audio/strawberry/distinfo | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-)
Nevermind, it seems iconv:wchar_t works now. I will update the patch.
Created attachment 235333 [details] v2
Well it seems that both 'iconv:wchar_t' and 'iconv:translit' pet Q/A tests. I will investigate it to find the correct option for this port. Cheers
(In reply to Nuno Teixeira from comment #7) So should I let iconv alone? Because with only iconv it complains about the warning you pointed out. They both work for the application functionality as far as I've tested (I use this application daily).
I've got some help on freebsd-ports mailing and I found: --- src/core/utilities.cpp: iconv_t conv = iconv_open("ASCII//TRANSLIT", "UTF-8"); --- So, let's use iconv:translit Cheers
(...) freebsd-ports: https://lists.freebsd.org/archives/freebsd-ports/2022-July/002237.html
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=7414f24176d5de3e3c5ef7159532545a2bbf616d commit 7414f24176d5de3e3c5ef7159532545a2bbf616d Author: Nuno Teixeira <eduardo@FreeBSD.org> AuthorDate: 2022-07-19 08:28:55 +0000 Commit: Nuno Teixeira <eduardo@FreeBSD.org> CommitDate: 2022-07-19 08:36:30 +0000 audio/strawberry: Use iconv:translit - use USES= 'iconv:translit' instead of 'iconv' to pet Q/A checks about converters/libiconv not declared as a dependency. Source code gives some hints about 'translit': "src/core/utilities.cpp: iconv_t conv = iconv_open("ASCII//TRANSLIT", "UTF-8");" - reorder variables (pet portfmt) - bump PORTREVISION PR: 265290 audio/strawberry/Makefile | 28 ++++++++++++++-------------- 1 file changed, 14 insertions(+), 14 deletions(-)
Committed, thanks!