Created attachment 235440 [details] graphics/bonzomatic: fix build on armv6 armv7 arm64 Add a missing cast the compiler was complaining about. Tested with Poudriere on armv7 arm64 FreeBSD 13. Please MFH if possible.
Have you submitted this upstream?
(In reply to Dmitry Marakasov from comment #1) No.
Please do. This fix does not seem to be FreeBSD specific and should be upstreamed.
(In reply to Dmitry Marakasov from comment #3) Sure, I'll do that after you have committed the patch I sent you. I do not like build fixes being hung on an upstream that may or may not respond.
Sorry, I'm not going to accept this until upstream PR is created.
Okay.
This is pending upstream PR submission.
(In reply to Dmitry Marakasov from comment #7) Which I am not going to do before the patch is committed. Hence “not accepted.”
I can do it myself if you are not interested in doing it right, and doing it right implies making upstream aware of the problem. It's pretty simple, and I don't see any reason for making a scene out of it.
(In reply to Dmitry Marakasov from comment #9) My current objective is to work through the ports collection and fix build issues on armv7 as they crop up. I've had bad experiences with other ports were a build fix was delayed indefinitely and I had lots of busywork to do because the maintainer wanted upstream to fix this instead of committing a patch locally. I am once again happy to file a bug report with upstream, but I do not accept that as a condition to have the patch applied. After the patch is applied, I can of course file a bug report so upstream can fix the issue and take all the time in the world to do it while the FreeBSD ports is in working order. However, I do not want to be part of that. I do not like to be sent on errands with the vacuous promise of having the patch applied maybe some day when the stars are right and upstream decides to respond. Have played this game too often and it just stops me from doing productive work.
Hi there, Any progress with this one?
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=a811d270e8259c51e78878a2f04f962555f9cf90 commit a811d270e8259c51e78878a2f04f962555f9cf90 Author: Dmitry Marakasov <amdmi3@FreeBSD.org> AuthorDate: 2022-08-12 12:23:12 +0000 Commit: Dmitry Marakasov <amdmi3@FreeBSD.org> CommitDate: 2022-08-12 12:23:50 +0000 graphics/bonzomatic: fix build on arm* PR: 265405 Submitted by: fuz@fuz.su graphics/bonzomatic/files/patch-src_main.cpp (new) | 11 +++++++++++ 1 file changed, 11 insertions(+)
Issue reported upstream. https://github.com/Gargaj/Bonzomatic/issues/172
It's quite sudden to ask this. Unfortunately you have one-sided position, and as a result you're making _me_ do _your_ errands for the sake of your task, and it as well stops me from doing productive work. Next time please be sure to submit upstream PR first before submitting a patch to my ports. Note that there's absolutely no requirement to get the fix committed upstream and I'm absolutely fine with just issue or PR submitted. The main goal is to make problem globally visible instead of pulluting the tree with patches Upstream PR: https://github.com/Gargaj/Bonzomatic/pull/171
Hi, You can be sure that if requested, I'll submit a PR as soon as the patch is committed to ports. As a compromise, I will try to no longer submit patches for any of your ports. This way, your preferred process will no longer be interfered with.
Seems like upstream committed the patch (yay!). Can this be closed now?