Bug 265483 - math/linbox: fix build on armv7
Summary: math/linbox: fix build on armv7
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Thierry Thomas
URL: https://github.com/linbox-team/linbox...
Keywords:
Depends on:
Blocks:
 
Reported: 2022-07-28 17:57 UTC by Robert Clausecker
Modified: 2022-07-31 20:34 UTC (History)
1 user (show)

See Also:
thierry: maintainer-feedback+
thierry: merge-quarterly+


Attachments
math/linbox: fix build on armv7 (8.10 KB, patch)
2022-07-28 17:57 UTC, Robert Clausecker
fuz: maintainer-approval? (thierry)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Clausecker freebsd_committer freebsd_triage 2022-07-28 17:57:03 UTC
Created attachment 235530 [details]
math/linbox: fix build on armv7

- add missing casts in RNG initialisation
 - import an upstream patch to avoid unaligned memory access

See also: https://github.com/linbox-team/linbox/issues/238
Tested with Poudriere on armv7 FreeBSD 13.1.
The test suite passes.
Please MFH if possible.
Comment 1 Thierry Thomas freebsd_committer freebsd_triage 2022-07-29 12:40:14 UTC
Thanks for the investigation!

But I have a question: why to you take a patch partly from GitHub (with PATCHFILES), and the others locally as port patches?
Comment 2 Robert Clausecker freebsd_committer freebsd_triage 2022-07-29 13:38:52 UTC
(In reply to Thierry Thomas from comment #1)

Because I wrote the local patches myself while taking the github patch from github.
Comment 3 Thierry Thomas freebsd_committer freebsd_triage 2022-07-31 20:30:14 UTC
Committed, thanks!
Comment 4 commit-hook freebsd_committer freebsd_triage 2022-07-31 20:30:55 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=5ce6a5a14720989cb67a86be605d174db4308dfb

commit 5ce6a5a14720989cb67a86be605d174db4308dfb
Author:     Robert Clausecker <fuz@fuz.su>
AuthorDate: 2022-07-31 15:26:50 +0000
Commit:     Thierry Thomas <thierry@FreeBSD.org>
CommitDate: 2022-07-31 20:29:39 +0000

    math/linbox: fix build on armv7

    - add missing casts in RNG initialisation
    - import an upstream patch to avoid unaligned memory access

    PR:             265483
    Reported by:    Robert Clausecker <fuz (at) fuz.su>

 math/linbox/Makefile                                 |  5 ++++-
 math/linbox/distinfo                                 |  4 +++-
 .../files/patch-linbox_randiter_ntl-zz.h (new)       | 11 +++++++++++
 .../files/patch-linbox_ring_ntl_ntl-gf2e.h (new)     | 20 ++++++++++++++++++++
 .../files/patch-linbox_ring_ntl_ntl-lzz__pe.h (new)  | 20 ++++++++++++++++++++
 .../files/patch-linbox_ring_ntl_ntl-lzz__pex.h (new) | 20 ++++++++++++++++++++
 .../files/patch-linbox_ring_ntl_ntl-lzz__px.h (new)  | 20 ++++++++++++++++++++
 .../files/patch-linbox_ring_ntl_ntl-zz__pe.h (new)   | 20 ++++++++++++++++++++
 8 files changed, 118 insertions(+), 2 deletions(-)
Comment 5 commit-hook freebsd_committer freebsd_triage 2022-07-31 20:34:56 UTC
A commit in branch 2022Q3 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=bc2786a965bbbbff92768279845f322dc6f2677a

commit bc2786a965bbbbff92768279845f322dc6f2677a
Author:     Robert Clausecker <fuz@fuz.su>
AuthorDate: 2022-07-31 15:26:50 +0000
Commit:     Thierry Thomas <thierry@FreeBSD.org>
CommitDate: 2022-07-31 20:34:01 +0000

    math/linbox: fix build on armv7

    - add missing casts in RNG initialisation
    - import an upstream patch to avoid unaligned memory access

    PR:             265483
    Reported by:    Robert Clausecker <fuz (at) fuz.su>

    (cherry picked from commit 5ce6a5a14720989cb67a86be605d174db4308dfb)

 math/linbox/Makefile                                 |  5 ++++-
 math/linbox/distinfo                                 |  4 +++-
 .../files/patch-linbox_randiter_ntl-zz.h (new)       | 11 +++++++++++
 .../files/patch-linbox_ring_ntl_ntl-gf2e.h (new)     | 20 ++++++++++++++++++++
 .../files/patch-linbox_ring_ntl_ntl-lzz__pe.h (new)  | 20 ++++++++++++++++++++
 .../files/patch-linbox_ring_ntl_ntl-lzz__pex.h (new) | 20 ++++++++++++++++++++
 .../files/patch-linbox_ring_ntl_ntl-lzz__px.h (new)  | 20 ++++++++++++++++++++
 .../files/patch-linbox_ring_ntl_ntl-zz__pe.h (new)   | 20 ++++++++++++++++++++
 8 files changed, 118 insertions(+), 2 deletions(-)