Bug 265578 - x11/xdm: Update to 1.1.13 and allow X server arguments to be set in Xservers
Summary: x11/xdm: Update to 1.1.13 and allow X server arguments to be set in Xservers
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Kevin Bowling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-08-02 16:18 UTC by Chris Mangin
Modified: 2023-08-12 20:21 UTC (History)
1 user (show)

See Also:
kbowling: maintainer-feedback+


Attachments
Patch to the x11/xdm port (744 bytes, patch)
2022-08-02 16:18 UTC, Chris Mangin
no flags Details | Diff
Update to 1.1.13 (1.47 KB, patch)
2022-09-10 13:34 UTC, Chris Mangin
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Mangin 2022-08-02 16:18:10 UTC
Created attachment 235637 [details]
Patch to the x11/xdm port

Currently the X server arguments are unconditionally set in the rc.d script. As a consequence, xdm ignores any X server argument set in the /usr/local/etc/X11/xdm/Xservers file which should be the normal way to do this.

This patch changes the rc.d script so that:

1- The xdm_tty variable is set to 'default'. This disable the override and allows xdm to be configured the normal way. xdm uses the ttyv8 terminal by default anyway.

2- The server arguments are only overridden if the user explicitly specify a value for xdm_tty.
Comment 1 Chris Mangin 2022-09-10 13:34:09 UTC
Created attachment 236474 [details]
Update to 1.1.13

Refresh patch to update to version 1.1.13
Comment 2 commit-hook freebsd_committer freebsd_triage 2023-08-12 20:20:18 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=ba250e03fd652940d2da0e4d947dca35e26b5a4c

commit ba250e03fd652940d2da0e4d947dca35e26b5a4c
Author:     Chris Mangin <cmangin@arobas.net>
AuthorDate: 2023-08-12 20:18:07 +0000
Commit:     Kevin Bowling <kbowling@FreeBSD.org>
CommitDate: 2023-08-12 20:19:38 +0000

    x11/xdm: allow X server arguments to be set in Xservers

    This patch changes the rc.d script so that:

    1- The xdm_tty variable is set to 'default'. This disable the override
    and allows xdm to be configured the normal way. xdm uses the ttyv8
    terminal by default anyway.

    2- The server arguments are only overridden if the user explicitly
    specify a value for xdm_tty.

    PR:             265578

 x11/xdm/Makefile     | 2 +-
 x11/xdm/files/xdm.in | 6 ++++--
 2 files changed, 5 insertions(+), 3 deletions(-)