Bug 265729 - textproc/gnugrep: Add 'g' prefix
Summary: textproc/gnugrep: Add 'g' prefix
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Alexey Dokuchaev
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-08-09 09:02 UTC by Loïc Bartoletti
Modified: 2022-08-11 10:32 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (danfe)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Loïc Bartoletti freebsd_committer freebsd_triage 2022-08-09 09:02:15 UTC
Hi danfe@,

On many systems (all except gnu based?), gnutools are prefixed with 'g':

- https://github.com/NetBSD/pkgsrc/blob/trunk/textproc/grep/Makefile#L18
- http://cvsweb.openbsd.org/cgi-bin/cvsweb/ports/sysutils/ggrep/Makefile?rev=1.41&content-type=text/x-cvsweb-markup

same on macOs, etc

Our gsed, also have this 'g' program-prefix:

- https://github.com/freebsd/freebsd-ports/blob/main/textproc/gsed/Makefile#L16

Please, can we prefix the gnugrep ports with 'g' or at least create a symlink?
Comment 1 commit-hook freebsd_committer freebsd_triage 2022-08-11 10:15:43 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=f515b0e657e7bd11d88725e9bc3cb1ccb3706baa

commit f515b0e657e7bd11d88725e9bc3cb1ccb3706baa
Author:     Alexey Dokuchaev <danfe@FreeBSD.org>
AuthorDate: 2022-08-11 10:13:08 +0000
Commit:     Alexey Dokuchaev <danfe@FreeBSD.org>
CommitDate: 2022-08-11 10:13:08 +0000

    textproc/gnugrep: add missing dependency, build with --program-prefix=g

    - Add run-time dependency on `textproc/groff': the manual page won't be
      rendered if groff(1) is not installed;
    - By popular demand, configure the port with `--program-prefix=g' as we
      do for other GNU utilities.  This places the binaries within the same
      namespace more consistently; several other non-GNU/Linux systems, e.g.
      NetBSD, OpenBSD, Solaris, macOS (Homebrew) are doing the same.  Avoid
      POLA violation by creating traditionally named compatibility symlinks.

    PR:     263275, 265729

 textproc/gnugrep/Makefile  | 9 +++++++++
 textproc/gnugrep/pkg-plist | 9 ++++++---
 2 files changed, 15 insertions(+), 3 deletions(-)
Comment 2 Alexey Dokuchaev freebsd_committer freebsd_triage 2022-08-11 10:18:05 UTC
After some consideration, I guess it does make sense, committed!
Comment 3 Loïc Bartoletti freebsd_committer freebsd_triage 2022-08-11 10:32:43 UTC
(In reply to Alexey Dokuchaev from comment #2)
Thanks!