Created attachment 235843 [details] patch for print/epson-inkjet-printer-escpr2 epson-inkjet-printer-escpr2 has been updated to 1.1.49. Supported new models New PPD files for the following models have been added. WF-2960 series XP-5200 series Tentatively fixed an issue where extraction would fail if certain conditions were not met. Extraction was not successful except in environments where PACKAGE_BUILDING is defined (e.g. on poudriere jail or make -D PACKAGE_BUILDING extract) or when the target makesum is used (e.g. make makesum stage). Sorry, I think someone already pointed this out, but I finally understand ;) The build has been successful in the following environments in poudriere. 12.3-STABLE 1203507 amd64 In the following environment, only the execution of check-plist by hand was verified. 12.3-RELEASE-p6 i386
(In reply to Tatsuki Makino from comment #0) Hi, =======================<phase: check-sanity >============================ ===> epson-inkjet-printer-escpr2-1.1.49 License EPSON LGPL21 needs confirmation, but BATCH is defined. *** Error code 1 Do you get this error under porudriere?
(In reply to Nuno Teixeira from comment #1) Yes. So in my poudriere, I have the following in make.conf. LICENSES_ACCEPTED=${LICENSE} This is acceptable under any license :)
(In reply to Tatsuki Makino from comment #2) I've added it to /etc/make.conf but error build remains. I will put this PR back to pool and wait for a solution. Cheers
(In reply to Tatsuki Makino from comment #2) (...) And I've checked and no packages are available. Is this intentional?
(In reply to Nuno Teixeira from comment #3) The path to make.conf, which acts on all jails, porttrees, and sets in poudriere, is /usr/local/etc/poudriere.d/make.conf. LICENSES_ACCEPTED=${LICENSE} will be written in the file there. However, there may have been options in the poudriere that would not have required this :) (In reply to Nuno Teixeira from comment #4) It includes a binary core library and an open source wrapper that uses the core library. The part of the distribution in binary is supposed to be subject to non-redistribution, so we do so in the LICENSE* variables.
(In reply to Tatsuki Makino from comment #5) Thanks for explanation. I can understand it now: --- ====> Running Q/A tests (stage-qa) Warning: Bad symlink '/usr/local/share/cups/model/epson-inkjet-printer-escpr2' pointing to an absolute pathname '/compat/linux/opt/epson-inkjet-printer-escpr2/ppds/Epson' Warning: License is not auto-accepted, packages will not be built, ports depending on this one will be ignored. Warning: License does not allow package to be distributed, ports depending on this one will be ignored --- Cheers
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=c1bbdb89c10b23d3cc87de1ada3eefed95beca3a commit c1bbdb89c10b23d3cc87de1ada3eefed95beca3a Author: Tatsuki Makino <tatsuki_makino@hotmail.com> AuthorDate: 2022-08-11 22:18:11 +0000 Commit: Nuno Teixeira <eduardo@FreeBSD.org> CommitDate: 2022-08-11 22:18:11 +0000 print/epson-inkjet-printer-escpr2: Update to 1.1.49 - Supported new models New PPD files for the following models have been added. WF-2960 series XP-5200 series Tentatively fixed an issue where extraction would fail if certain conditions were not met. Extraction was not successful except in environments where PACKAGE_BUILDING is defined (e.g. on poudriere jail or `make -D \ PACKAGE_BUILDING extract`) or when the target makesum is used (e.g. `make makesum stage`). PR: 265774 print/epson-inkjet-printer-escpr2/Makefile | 17 +++++++++-------- print/epson-inkjet-printer-escpr2/distinfo | 14 +++++++------- print/epson-inkjet-printer-escpr2/pkg-plist | 2 ++ 3 files changed, 18 insertions(+), 15 deletions(-)
Committed, thanks!
Thank you very much, and thank you also for bug 265773. Also, /compat/linux is hardcoded, so absolute pathname warning of comment #6 cannot be resolved.