Bug 265819 - devel/xxhash: fix static_assert bug
Summary: devel/xxhash: fix static_assert bug
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Matthias Andree
URL:
Keywords:
Depends on:
Blocks: 265060
  Show dependency tree / graph
 
Reported: 2022-08-13 17:16 UTC by Thierry Dussuet
Modified: 2022-08-13 18:55 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (sunpoet)
mandree: merge-quarterly+

Attachments
Replace static_assert by _Static_assert in xxhash.h (873 bytes, patch)
2022-08-13 17:16 UTC, Thierry Dussuet 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Thierry Dussuet 2022-08-13 17:16:32 UTC 
Created attachment 235882 [details]
Replace static_assert by _Static_assert in xxhash.h

xxHash had a bug fixed in December 2021 regarding static_assert (https://github.com/Cyan4973/xxHash/pull/670). While they did not release a new version yet which would include this bugfix, it is affecting other ports, like backup/py-borgbackup. It would be nice to include this patch into the FreeBSD port so this library can be used again.
Comment 1 Matthias Andree freebsd_committer freebsd_triage 2022-08-13 17:28:06 UTC 
I'll claim this under portmgr@ blanket approval to fix downstream ports.
Comment 2 commit-hook freebsd_committer freebsd_triage 2022-08-13 18:52:30 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=8a4d5e26a9721eae2deba5fef794a2e593170658

commit 8a4d5e26a9721eae2deba5fef794a2e593170658
Author:     Thierry Dussuet <thierry.dussuet@protonmail.com>
AuthorDate: 2022-08-13 18:35:43 +0000
Commit:     Matthias Andree <mandree@FreeBSD.org>
CommitDate: 2022-08-13 18:43:27 +0000

    devel/xxhash: fix static_assert to _Static_assert

    This fixes C11+ users of xxhash that do not #include <assert.h>

    PR:             265819
    Approved by:    portmgr@ (blanket, one-line fix to unbreak py-borgbackup)
    MFH:            2022Q3

 devel/xxhash/Makefile                   |  2 +-
 devel/xxhash/files/patch-xxhash.h (new) | 12 ++++++++++++
 2 files changed, 13 insertions(+), 1 deletion(-)
Comment 3 commit-hook freebsd_committer freebsd_triage 2022-08-13 18:55:37 UTC 
A commit in branch 2022Q3 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=4d45e445eb831ec162b4d92e89a7b83878d14f9d

commit 4d45e445eb831ec162b4d92e89a7b83878d14f9d
Author:     Thierry Dussuet <thierry.dussuet@protonmail.com>
AuthorDate: 2022-08-13 18:35:43 +0000
Commit:     Matthias Andree <mandree@FreeBSD.org>
CommitDate: 2022-08-13 18:52:06 +0000

    devel/xxhash: fix static_assert to _Static_assert

    This fixes C11+ users of xxhash that do not #include <assert.h>

    PR:             265819
    Approved by:    portmgr@ (blanket, one-line fix to unbreak py-borgbackup)
    MFH:            2022Q3

    (cherry picked from commit 8a4d5e26a9721eae2deba5fef794a2e593170658)

 devel/xxhash/Makefile                   |  2 +-
 devel/xxhash/files/patch-xxhash.h (new) | 12 ++++++++++++
 2 files changed, 13 insertions(+), 1 deletion(-)