Bug 265850 - net-im/dino: fix crash on call
Summary: net-im/dino: fix crash on call
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Ashish SHUKLA
URL: https://github.com/dino/dino/issues/1227
Keywords:
Depends on:
Blocks:
 
Reported: 2022-08-15 09:17 UTC by Ivan Rozhuk
Modified: 2022-08-21 16:57 UTC (History)
1 user (show)

See Also:
ashish: maintainer-feedback+

Attachments
patch (1.90 KB, patch)
2022-08-15 09:17 UTC, Ivan Rozhuk 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ivan Rozhuk 2022-08-15 09:17:49 UTC 
Created attachment 235916 [details]
patch

https://github.com/dino/dino/issues/1227
Comment 1 Ivan Rozhuk 2022-08-15 09:31:45 UTC 
https://github.com/dino/dino/pull/1259
Comment 2 Ashish SHUKLA freebsd_committer freebsd_triage 2022-08-16 07:51:19 UTC 
I've subscribed myself to the upstream issue/PRs, once upstream approves it, I'll include them in the port.

As I'm not near my FreeBSD desktop for few weeks, I will not able to reproduce the problem.

Thanks!
Comment 3 Ivan Rozhuk 2022-08-17 01:40:19 UTC 
Upstream latest commit: May 17.
Not sure how many time they need to respond.
Comment 4 Ashish SHUKLA freebsd_committer freebsd_triage 2022-08-21 16:41:20 UTC 
(In reply to Ivan Rozhuk from comment #3)

I won't be able to test your changes, but if they work for you, and they seem to apply fine, then I'll commit them, after the build succeeds.

And there has been commits to upstream project lately, so the project is not inactive.

Thanks!
Comment 5 commit-hook freebsd_committer freebsd_triage 2022-08-21 16:56:34 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=39dce0e63898092d93f1db6ee4850bef90673b76

commit 39dce0e63898092d93f1db6ee4850bef90673b76
Author:     Rozhuk Ivan <rozhuk.im@gmail.com>
AuthorDate: 2022-08-15 09:13:55 +0000
Commit:     Ashish SHUKLA <ashish@FreeBSD.org>
CommitDate: 2022-08-21 16:54:58 +0000

    net-im/dino: fix crash on call

    PR:             265850

 net-im/dino/Makefile                                       |  2 +-
 .../patch-libdino_src_service_call__peer__state.vala (new) | 14 ++++++++++++++
 2 files changed, 15 insertions(+), 1 deletion(-)
Comment 6 Ashish SHUKLA freebsd_committer freebsd_triage 2022-08-21 16:57:03 UTC 
Committed, thanks!