Bug 265861 - net-mgmt/netdata: Update to v1.36.1 and fix LTO=on builds
Summary: net-mgmt/netdata: Update to v1.36.1 and fix LTO=on builds
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Neel Chauhan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-08-15 19:42 UTC by Namkhai B.
Modified: 2022-12-13 03:25 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (nc)


Attachments
net-mgmt/netdata: Update to v1.36.1 and fix LTO=on builds (1.83 KB, patch)
2022-08-15 19:42 UTC, Namkhai B.
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Namkhai B. 2022-08-15 19:42:52 UTC
Created attachment 235924 [details]
net-mgmt/netdata: Update to v1.36.1 and fix LTO=on builds

This patch updates netdata to v1.36.1 and fixes LTO=on builds.

See https://github.com/netdata/netdata/issues/13522 for reference.
Comment 1 Namkhai B. 2022-08-15 19:58:25 UTC
Digging more deeply it seems it's something else. Build fails when LTO=on and DBENGINE=on. Please hold off committing this until I figure what's going on.
Comment 2 Neel Chauhan freebsd_committer freebsd_triage 2022-08-15 20:46:57 UTC
LGTM. will commit shortly.
Comment 3 Neel Chauhan freebsd_committer freebsd_triage 2022-08-15 20:48:01 UTC
Committed!
Comment 4 commit-hook freebsd_committer freebsd_triage 2022-08-15 20:48:47 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=f21fe5374167fedad8acc498fdfbdfddf2439861

commit f21fe5374167fedad8acc498fdfbdfddf2439861
Author:     Namkhai B <me@forkbomb9.ch>
AuthorDate: 2022-08-15 20:47:29 +0000
Commit:     Neel Chauhan <nc@FreeBSD.org>
CommitDate: 2022-08-15 20:47:29 +0000

    net-mgmt/netdata: Update to v1.36.1 and fix LTO=on builds

    PR:     265861

 net-mgmt/netdata/Makefile | 3 ++-
 net-mgmt/netdata/distinfo | 6 +++---
 2 files changed, 5 insertions(+), 4 deletions(-)
Comment 5 Daniel Engberg freebsd_committer freebsd_triage 2022-08-15 22:19:53 UTC
@ Neel
Please be more careful before committing, your commit is wrong (why would LTO depends on a separate library?) and it's still broken.

See https://github.com/netdata/netdata/issues/13520 for more information