Bug 265895 - devel/gopls: update to 0.9.4
Summary: devel/gopls: update to 0.9.4
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Fernando Apesteguía
URL: https://github.com/golang/tools/relea...
Keywords:
Depends on:
Blocks:
 
Reported: 2022-08-17 04:49 UTC by Robert Clausecker
Modified: 2022-08-17 16:06 UTC (History)
1 user (show)

See Also:
fernape: merge-quarterly+

Attachments
https://github.com/golang/tools/releases/tag/gopls%2Fv0.9.4 (1.57 KB, patch)
2022-08-17 04:49 UTC, Robert Clausecker 		fuz: maintainer-approval+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Clausecker freebsd_committer freebsd_triage 2022-08-17 04:49:26 UTC 
Created attachment 235956 [details]
https://github.com/golang/tools/releases/tag/gopls%2Fv0.9.4

A bug fix release.

Changelog: https://github.com/golang/tools/releases/tag/gopls%2Fv0.9.4

Tested with Poudriere on armv7 arm64 FreeBSD 13.1.
Please MFH this patch release.
Comment 1 commit-hook freebsd_committer freebsd_triage 2022-08-17 16:00:14 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=6d7825177b5a9ddd7ffc28adcda55d3f04ddab58

commit 6d7825177b5a9ddd7ffc28adcda55d3f04ddab58
Author:     Robert Clausecker <fuz@fuz.su>
AuthorDate: 2022-08-17 05:42:11 +0000
Commit:     Fernando Apesteguía <fernape@FreeBSD.org>
CommitDate: 2022-08-17 15:56:34 +0000

    devel/gopls: update to 0.9.4

    ChangeLog: https://github.com/golang/tools/releases/tag/gopls%2Fv0.9.4

    This release fixes an unfortunate bug in a new vet analysis in the gopls@v0.9.2
    release. Specifically, a stray print statement in a new analyzer for the invalid
    time format string "2006-02-01", which corrupts gopls' communication over
    STDIN/STDOUT.

    PR:             265895
    Reported by:    fuz@fuz.su (maintainer)
    MFH:            2022Q3

 devel/gopls/Makefile |  2 +-
 devel/gopls/distinfo | 10 +++++-----
 2 files changed, 6 insertions(+), 6 deletions(-)
Comment 2 Fernando Apesteguía freebsd_committer freebsd_triage 2022-08-17 16:05:55 UTC 
Committed and merged to 2022Q3

Thanks!
Comment 3 commit-hook freebsd_committer freebsd_triage 2022-08-17 16:06:16 UTC 
A commit in branch 2022Q3 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=f22ec54de2594789ecf1420cbddd46794f0535ca

commit f22ec54de2594789ecf1420cbddd46794f0535ca
Author:     Robert Clausecker <fuz@fuz.su>
AuthorDate: 2022-08-17 05:42:11 +0000
Commit:     Fernando Apesteguía <fernape@FreeBSD.org>
CommitDate: 2022-08-17 16:01:27 +0000

    devel/gopls: update to 0.9.4

    ChangeLog: https://github.com/golang/tools/releases/tag/gopls%2Fv0.9.4

    This release fixes an unfortunate bug in a new vet analysis in the gopls@v0.9.2
    release. Specifically, a stray print statement in a new analyzer for the invalid
    time format string "2006-02-01", which corrupts gopls' communication over
    STDIN/STDOUT.

    PR:             265895
    Reported by:    fuz@fuz.su (maintainer)
    MFH:            2022Q3

    (cherry picked from commit 6d7825177b5a9ddd7ffc28adcda55d3f04ddab58)

 devel/gopls/Makefile |  3 +--
 devel/gopls/distinfo | 10 +++++-----
 2 files changed, 6 insertions(+), 7 deletions(-)