Created attachment 236116 [details] patch dar 2.5.14 to 2.7.7 New features such as remote FTP/sFTP server and multi threading are not available. For this we need to make a new port libthreadar. https://sourceforge.net/projects/libthreadar/
Created attachment 236129 [details] new port sysutils/libthreadar
Created attachment 236130 [details] multithreading dar 2.7.7 FTP/sFTP remote storage require additional testing. It doesn't work for me. But multithreaded compression and encryption is Ok.
Created attachment 236131 [details] patch dar 2.5.14 to 2.7.7 without libpthread Corrected version without libpthread.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=1ff0df1aea00ecc0945f89f02e853f3732969e9c commit 1ff0df1aea00ecc0945f89f02e853f3732969e9c Author: Muhammad Moinur Rahman <bofh@FreeBSD.org> AuthorDate: 2022-08-28 20:16:23 +0000 Commit: Muhammad Moinur Rahman <bofh@FreeBSD.org> CommitDate: 2022-08-28 20:18:55 +0000 devel/libthreader: New port Libthreadar is a C++ library providing an abstracted set of C++ *classes* to manipulate threads in a very simple and efficient way from your C++ code. It's used to support multithreading in the DAR archiver. WWW: https://libthreadar.sourceforge.net/ PR: 266040 Reported by: igorz@yandex.ru devel/Makefile | 1 + devel/libthreader/Makefile (new) | 20 ++++++++++++++++++++ devel/libthreader/distinfo (new) | 3 +++ devel/libthreader/pkg-descr (new) | 6 ++++++ devel/libthreader/pkg-plist (new) | 19 +++++++++++++++++++ 5 files changed, 49 insertions(+)
I think we should enable encryption by default. Encrypted backup is the right thing. And all other functional options too. Since a binary package is usually installed. There will be a complete backup solution. Remote storage was broken several versions ago. I have tested win64 versions up to 2.7.7. The latest fully working with FTP is version 2.6.15. I reported the error to the author.
Created attachment 236186 [details] dar 2.7.7 full set of options Everything unnecessary can be disabled in the ports.
As I have already committed libthreader; can you please remove/mark obsolete all the unnecessary patches those are here as it creates confusion?
Comment on attachment 236129 [details] new port sysutils/libthreadar Already committed.
Thanks. Is it possible for you to make the patch out of git diff rather than folder style diff? As that is hard to apply in our tree.
(In reply to Muhammad Moinur Rahman from comment #8) There's a wrong name here devel/libthreader libthreadAr, not "...der"
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=aa6fe060d5751454e099c3664864cc9b8877811b commit aa6fe060d5751454e099c3664864cc9b8877811b Author: Muhammad Moinur Rahman <bofh@FreeBSD.org> AuthorDate: 2022-08-29 09:13:20 +0000 Commit: Muhammad Moinur Rahman <bofh@FreeBSD.org> CommitDate: 2022-08-29 09:18:08 +0000 devel/libthreader: Rename to devel/libthreadar Fix directory name PR: 266040 Fixes: 1ff0df devel/libthreader: New port MOVED | 1 + devel/{libthreader => libthreadar}/Makefile | 0 devel/{libthreader => libthreadar}/distinfo | 0 devel/{libthreader => libthreadar}/pkg-descr | 0 devel/{libthreader => libthreadar}/pkg-plist | 0 5 files changed, 1 insertion(+)
(In reply to Igor Zabelin from comment #10) Okiz. Fixed.
(In reply to Muhammad Moinur Rahman from comment #12) /!\ libthreadar-1.4.0: Makefile errors /!\ The first entry in CATEGORIES should be the directory where the port lives CATEGORIES= devel sysutils
(In reply to Igor Zabelin from comment #13) Please do not mix and match your development environment and the source of truth. In case you see from my commit I have moved the library to the devel directory as we try to keep the libraries there.
Created attachment 236210 [details] git diff
Build fails on 12. In case you have some times can you have a look at the logs here: https://pdr.bofh.network/data/latest-per-pkg/dar/2.7.7/ 123 and 123i386
Created attachment 236394 [details] git diff v2 Not built with clang at least versions 10 and 11. I wrote to the author. Well, then multithreading will be optional for future versions. Here is a patch for a simpler "classic" edition.
I checked the latest patch on 12.3. It's ok. The problem is only with multithreading.
Created attachment 236411 [details] multithreading dar 2.7.7 Fixed a build issue with clang 10
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=4f64852f780b438de7c7cf0a36e3f55c27212fae commit 4f64852f780b438de7c7cf0a36e3f55c27212fae Author: Muhammad Moinur Rahman <bofh@FreeBSD.org> AuthorDate: 2022-09-27 19:56:51 +0000 Commit: Muhammad Moinur Rahman <bofh@FreeBSD.org> CommitDate: 2022-09-27 20:00:11 +0000 sysutils/dar: Update version 2.5.14=>2.7.7 - Uses new multithreading library - Add USES=pathfix - Housekeeping with portclippy and portfmt PR: 266040 Reported by: igorz@yandex.ru Relnotes: https://sourceforge.net/projects/dar/files/dar/2.7.7/ sysutils/dar/Makefile | 67 +++++++++------ sysutils/dar/distinfo | 6 +- ...tch-src_libdar_parallel__tronconneuse.cpp (new) | 28 +++++++ sysutils/dar/pkg-plist | 98 ++++++++++++---------- 4 files changed, 128 insertions(+), 71 deletions(-)