Bug 266041 - sysutils/loki: Fix runtime error with after runtime bump to go119
Summary: sysutils/loki: Fix runtime error with after runtime bump to go119
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Kurt Jaeger
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-08-25 21:38 UTC by Christopher Beppler
Modified: 2022-09-05 20:20 UTC (History)
1 user (show)

See Also:


Attachments
allows go119 runtime for loki binaries (6.46 KB, patch)
2022-08-25 21:38 UTC, Christopher Beppler
freebsd: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Christopher Beppler 2022-08-25 21:38:17 UTC
Created attachment 236117 [details]
allows go119 runtime for loki binaries

Loki uses go4.org/unsafe and the upstream dependency uses a version that doesn't allow go119. However, go4.org already asserts that go119 is fine.

Without this fix, you'll get errors like this when using any of the binaries:

panic: Something in this program imports go4.org/unsafe/assume-no-moving-gc to declare that it assumes a non-moving garbage collector, but your version of go4.org/unsafe/assume-no-moving-gc hasn't been updated to assert that it's safe against the go1.19 runtime. If you want to risk it, run with environment variable ASSUME_NO_MOVING_GC_UNSAFE_RISK_IT_WITH=go1.19 set. Notably, if go1.19 adds a moving garbage collector, this program is unsafe to use.
Comment 1 Kurt Jaeger freebsd_committer freebsd_triage 2022-09-05 20:19:53 UTC
Committed, thanks!
Comment 2 commit-hook freebsd_committer freebsd_triage 2022-09-05 20:20:04 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=c5b27101bd44148e7ddab559d96438e77c05acd3

commit c5b27101bd44148e7ddab559d96438e77c05acd3
Author:     Christopher Beppler <freebsd@funzi.org>
AuthorDate: 2022-09-05 20:18:25 +0000
Commit:     Kurt Jaeger <pi@FreeBSD.org>
CommitDate: 2022-09-05 20:19:27 +0000

    sysutils/loki: Fix runtime error with after runtime bump to go119

    PR:             266041
    Approved by:    maintainer

 sysutils/loki/Makefile                             |  6 +++---
 sysutils/loki/distinfo                             |  4 +++-
 sysutils/loki/files/patch-go.mod (new)             | 11 +++++++++++
 sysutils/loki/files/patch-go.sum (new)             | 11 +++++++++++
 sysutils/loki/files/patch-vendor_modules.txt (new) | 11 +++++++++++
 5 files changed, 39 insertions(+), 4 deletions(-)