Bug 266083 - www/mod_auth_gssapi: Update to 1.6.5
Summary: www/mod_auth_gssapi: Update to 1.6.5
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Nuno Teixeira
URL: https://github.com/gssapi/mod_auth_gs...
Keywords:
Depends on:
Blocks:
 
Reported: 2022-08-28 11:38 UTC by Christian Ullrich
Modified: 2022-08-30 11:18 UTC (History)
1 user (show)

See Also:


Attachments
Patch. (1.42 KB, text/plain)
2022-08-28 11:38 UTC, Christian Ullrich
chris: maintainer-approval+
Details
Patch to 1.6.5. (1.68 KB, patch)
2022-08-29 16:43 UTC, Christian Ullrich
chris: maintainer-approval+
Details | Diff
Better patch to 1.6.5. (1.91 KB, patch)
2022-08-30 06:58 UTC, Christian Ullrich
chris: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Christian Ullrich 2022-08-28 11:38:54 UTC
Created attachment 236177 [details]
Patch.

Update port to 1.6.4.
Comment 1 Nuno Teixeira freebsd_committer freebsd_triage 2022-08-29 16:34:41 UTC
Hi,

1.6.5 release is out. You could use this PR to update to it by changing PR title.

pkg-descr WWW needs to be updated to https://github.com/gssapi/mod_auth_gssapi

Cheers
Comment 2 Christian Ullrich 2022-08-29 16:43:55 UTC
Created attachment 236221 [details]
Patch to 1.6.5.

Updated. Thanks for the WWW thing; I caught it in the Makefile but not there.
Comment 3 Nuno Teixeira freebsd_committer freebsd_triage 2022-08-29 17:46:28 UTC
Hi,

Why is "PLIST_FILES=" using "@sample\ ${APACHEETCDIR}/modules.d/%%APMOD_FILE%%"
                                                                -------------^
where
"APMOD_FILE= 240_${PORTNAME}.conf.sample"?

portlint complains about it about why not using:
"PLIST_FILES=" using "@sample\ ${APACHEETCDIR}/modules.d/${APMOD_FILE}" instead?
                                                         ^------------
---
FATAL: PLIST_FILES: files cannot contain %%FOO%% variables.  Use make variables and logic instead
---
Comment 4 Christian Ullrich 2022-08-30 06:58:32 UTC
Created attachment 236239 [details]
Better patch to 1.6.5.

> Why is "PLIST_FILES=" using "@sample\ ${APACHEETCDIR}/modules.d/%%APMOD_FILE%%"

Because the port is older than that check in portlint, and I may have fallen into the bad habit of accepting a change as good if poudriere is happy with it. I will mend my ways.
Comment 5 commit-hook freebsd_committer freebsd_triage 2022-08-30 11:11:25 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=747116fce0f8fb468d5662a8897eed2bc903d89f

commit 747116fce0f8fb468d5662a8897eed2bc903d89f
Author:     Christian Ullrich <chris@chrullrich.net>
AuthorDate: 2022-08-30 11:07:20 +0000
Commit:     Nuno Teixeira <eduardo@FreeBSD.org>
CommitDate: 2022-08-30 11:10:25 +0000

    www/mod_auth_gssapi: Update to 1.6.5

     - GH_ACCOUNT changed: modauthgssapi -> gssapi
     - update WWW url

    ChangeLog:      https://github.com/gssapi/mod_auth_gssapi/releases/tag/v1.6.5
    PR:             266083

 www/mod_auth_gssapi/Makefile  | 6 +++---
 www/mod_auth_gssapi/distinfo  | 6 +++---
 www/mod_auth_gssapi/pkg-descr | 2 +-
 3 files changed, 7 insertions(+), 7 deletions(-)
Comment 6 Nuno Teixeira freebsd_committer freebsd_triage 2022-08-30 11:18:10 UTC
Committed, thanks!