Bug 266087 - mail/alpine: update to 2.26
Summary: mail/alpine: update to 2.26
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Nuno Teixeira
URL: https://alpineapp.email/alpine/release/
Keywords:
Depends on:
Blocks:
 
Reported: 2022-08-28 19:22 UTC by Martin Neubauer
Modified: 2022-09-09 10:26 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (mbeis)


Attachments
patch for mail/alpine updating to 2.26 (5.73 KB, patch)
2022-08-28 19:22 UTC, Martin Neubauer
no flags Details | Diff
mail/alpine: update to 2.26 (1.68 KB, patch)
2022-09-03 18:33 UTC, Marco Beishuizen
mbeis: maintainer-approval+
mbeis: maintainer-approval+
Details | Diff
mail/alpine: update to 2.26 v1 (6.17 KB, patch)
2022-09-07 17:28 UTC, Nuno Teixeira
eduardo: maintainer-approval? (mbeis)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Neubauer 2022-08-28 19:22:02 UTC
Created attachment 236183 [details]
patch for mail/alpine  updating to 2.26

- Update to version 2.26
- Update WWW
- Some Makefile massaging

N.B. That last point causes the patch to be somewhat noisy after a run of portfmt and a bit of reshuffling to pacify portlint/portclippy somewhat. As those changes, while affecting quite a few lines, were pretty mechanical I won't mind if a smaller patch just doing the version bump gets committed.
Comment 1 Marco Beishuizen 2022-09-03 18:33:25 UTC
Created attachment 236341 [details]
mail/alpine: update to 2.26

See https://alpineapp.email for the changes.
Comment 2 Marco Beishuizen 2022-09-03 18:40:04 UTC
The patch from Martin looks fine (including the cosmetic changes) but the development of the maildir patch and the alpine version are not in the same pace. I do like the change proposed by Martin but atm it doesn't work because of this. So for now just the alpine update.
Comment 3 Marco Beishuizen 2022-09-03 18:43:49 UTC
Comment on attachment 236183 [details]
patch for mail/alpine  updating to 2.26

The patch from Martin looks fine (including the cosmetic changes) but the development of the maildir patch and the alpine version are not in the same pace. I do like the change for the maildir patch proposed by Martin but atm it doesn't work because of this. So for now just the alpine update.
Comment 4 Nuno Teixeira freebsd_committer freebsd_triage 2022-09-07 17:28:26 UTC
Created attachment 236421 [details]
mail/alpine: update to 2.26 v1

sugestion:

- pet portclippy
- pet portfmt
- switch to MASTER_SITES= https://alpineapp.email/${PORTNAME}/release/src/
- switch to tar:xz static tarball
- remove GIT_COMMIT= 9726c098a739edfdca6218bc5dee104c310957e9
         GIT_COMMIT_SHORT= ${GIT_COMMIT:C/^(.......).*/\1/}
         WRKSRC= ${WRKDIR}/alpine-${GIT_COMMIT_SHORT}
- use USES= instead of USES+=
- update maildir option/patch to
  https://alpineapp.email/${PORTNAME}/patches/${DISTNAME}/
Comment 5 Nuno Teixeira freebsd_committer freebsd_triage 2022-09-07 17:35:33 UTC
(...)
- update WWW url to https://alpineapp.email/
Comment 6 Martin Neubauer 2022-09-08 15:44:57 UTC
(In reply to Nuno Teixeira from comment #4)
One minor note regarding MASTER_SITES: For my original submission I considered doing that change as well, but noticed there don't seem to be release tarballs for versions with patchlevel >=1 (or there are, but are clobbering the previous minor version.) With e.g. version 2.24.2 having been in ports, that didn't look purely theoretical either. Personally I'm not terribly invested either way, but want to at least point this out.
Comment 7 commit-hook freebsd_committer freebsd_triage 2022-09-09 10:26:26 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=07c5f71db8c5e915b2b8723ffc0d6b7ac68ee5d2

commit 07c5f71db8c5e915b2b8723ffc0d6b7ac68ee5d2
Author:     Martin Neubauer <m.ne@gmx.net>
AuthorDate: 2022-09-09 10:23:53 +0000
Commit:     Nuno Teixeira <eduardo@FreeBSD.org>
CommitDate: 2022-09-09 10:25:08 +0000

    mail/alpine: Update to 2.26

     - update WWW url

    ChangeLog:      https://alpineapp.email/alpine/release/
    PR:             266087

 mail/alpine/Makefile |  8 ++++----
 mail/alpine/distinfo | 10 +++++-----
 2 files changed, 9 insertions(+), 9 deletions(-)
Comment 8 Nuno Teixeira freebsd_committer freebsd_triage 2022-09-09 10:26:48 UTC
Committed, thanks!