Bug 266090 - textproc/ibus: upgrade to 1.5.27
Summary: textproc/ibus: upgrade to 1.5.27
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Nuno Teixeira
URL: https://github.com/ibus/ibus/releases...
Keywords:
Depends on:
Blocks:
 
Reported: 2022-08-28 22:08 UTC by Henry Hu
Modified: 2022-08-30 10:43 UTC (History)
1 user (show)

See Also:


Attachments
patch for 1.5.27 (2.19 KB, patch)
2022-08-28 22:08 UTC, Henry Hu
no flags Details | Diff
Poudriere log for 13.0-RELEASE/amd64 (823.07 KB, text/plain)
2022-08-28 22:09 UTC, Henry Hu
no flags Details
Poudriere log for 13.0-RELEASE/amd64 (v2) (823.53 KB, text/plain)
2022-08-28 22:35 UTC, Henry Hu
no flags Details
patch for 1.5.27 (v2) (2.76 KB, patch)
2022-08-28 22:36 UTC, Henry Hu
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Henry Hu 2022-08-28 22:08:37 UTC
Created attachment 236187 [details]
patch for 1.5.27

Update textproc/ibus to 1.5.27 from 1.5.24.
Although we've skipped several versions, it has not changed much. Changelog:

1.5.27 Latest

    Disable XKB engines in Plasma Wayland 230fb22 b4723eb 9ad0637
    ibusimcontext keycode - 8 for gtk3 keycode generation 8711dc8
    Revert CCedilla change for pt-BR in ibusimcontext 3e5fab4
    Update CI 47303a6 16df64e 79e446e
    Add IBUS_CAP_OSK to IBusCapabilite b94f0c1
    Enable ibus restart in GNOME desktop ab0d176
    Add ibus im-module command 965567d fee26c6 db2ef5d
    Implement new process_key_event for GTK4 c957c5f
    Add focus_in_id()/focus_out_id() class methods 92771d0
    Delete xkb:latam:: in denylist.txt 82e38d9
    Enhance Xutf8TextListToTextProperty d47dbfa
    Revert Emoji shoftcut key to Super-space 1520c39
    Update simple.xml with xkeyboard-config 2.36 ef9bd3b

Code Contributors:

    Fix refcounting issues (Carlos Garnacho) 17648f0
    Fix bashisms in org.freedesktop.IBus.session.GNOME.service (Mitsuya Shibata) f1c456d
    Update xkb-latin-layouts in gschema (Mike FABIAN) bca7bf0
    Use our own prefix to look up systemd user services dir (Naïm Favier) 9f62a40
    Add functionality to change IBus panel themes with available GTK themes (Hollow Man) 233a3f4 addab9f ff99828


1.5.26

    Enhance compose keys df664b1 19377ad
    Enhance Emoji features acc5570 104148b d9ff2bb
    Implement clear preedit for GTK4 5487a6b
    Calculate keycode from keysym in GTK3 forward-key-event 4957d14
    Fix to send char position at update_preedit_text f5757ad
    Deprecate gettext.bind_textdomain_codeset() since Python 3.8 28acfd4
    Fix ibus_key_event_from_string for gobject-introspection c69b61a
    Fix a key event loop with forwarding keys 6b979e7
    Delete gnome-autogen dependency 2bc47f0
    Change XKB layout string color in panel 0e118e7
    Add IBUS_INPUT_HINT_PRIVATE for browser private mode 0f1485b
    mkdir socket dirs instead of socket paths 787b564 dfd3fbf
    Add org.freedesktop.IBus.session.generic.service b5423f0
    Check XDG_SESSION_DESKTOP for Plasma desktop 1f27521
    Update simple.xml with xkeyboard-config 2.35.1 a3c0724
    Update ibusunicodegen.h with unicode-ucd 14.0.0 9bf9ef0
    Enhance CI fbea544 51e3295 d53d31d be17934 675b94f
    Fix typos a82bda5

Code Contributors:

    Fix wrong cursor location in gtk3 apps (Alynx Zhou) 936a0e7
    Update URLS (Eberhard Beilharz) ecca9db
    invalidate cache based on symlink mtime too (Naïm Favier) cfcc6f1
    Fix unref problems with floating references (Eberhard Beilharz) 5a455b1
    Update man page for Emoji shortcut key (Sibo Dong) ad95015
    Add systemd unit file (Carlos Garnacho) a076b38
    Fix forward key keycode for GTK4 (Changwoo Ryu) 5cfe838


1.5.25

    src/tests: Run gnome-session with no-overview mode 214b60a bc7811c ab6b958
    client/gtk2: Implement ibus_im_context_set_surrounding_with_selection() d105a39
    Code reviews e9e1642 17ae266
    src/ibuscomposetable: Do not include the same compose file a755d16
    src/ibusenginesimple: Multi_key to 0xB7 7e12d58 2fc1a02
    src/ibusenginesimple: Make Compose preedit less intrusive 3e2609e df49566 4259f16 5bd2ecc
    Change default Emoji shortcut key b952d30
    setup: Enhance engine search function a4939f6
    client/gtk2/ibusimcontext: Enable sync process in GTK4 a823161
    engine: Update simple.xml with xkeyboard-config 2.33 934c456 238eb61

Code Contributors:

    src/ibuscomposetable: Add support for the include directive (lf-) 9f9c88b
    src/ibuscomposetable: Fix a buffer overflow in compose handling (lf-) 7f09379
    client/x11: Add support for XFixes ClientDisconnectMode (Olivier Fourdan) 71ca4a9
    setup: Start ibus-daemon with the --daemonize option (Gunnar Hjalmarsson) e465011
    src: Fix a typo in ibusenginesimple.h (user202729) bc265fb
Comment 1 Henry Hu 2022-08-28 22:09:06 UTC
Created attachment 236188 [details]
Poudriere log for 13.0-RELEASE/amd64
Comment 2 Henry Hu 2022-08-28 22:13:06 UTC
I think I need to add some new deps first.
Comment 3 Henry Hu 2022-08-28 22:35:23 UTC
Created attachment 236189 [details]
Poudriere log for 13.0-RELEASE/amd64 (v2)
Comment 4 Henry Hu 2022-08-28 22:36:13 UTC
Created attachment 236190 [details]
patch for 1.5.27 (v2)

Added some deps.
stage-qa still reports an issue with harfbuzz. I don't see ibus using that directly, so likely it's introduced by pango, not ibus itself.
Comment 5 Nuno Teixeira freebsd_committer freebsd_triage 2022-08-29 16:19:28 UTC
(In reply to Henry Hu from comment #4)
Hi,

harfbuzz is listed in shared libraries:
---
0x0000000000000001 NEEDED               Shared library: [libharfbuzz.so.0]
---
so, the better is to add LIB_DEPENDS+=libharfbuzz.so:print/harfbuzz

Cheers
Comment 6 Henry Hu 2022-08-30 00:11:59 UTC
(In reply to Nuno Teixeira from comment #5)
As I mentioned in comment 4, this port does not use harfbuzz directly. It's linked to it because of the usage of GTK2/GTK3:

> pkgconf --libs gtk+-2.0
-L/usr/local/lib -lgtk-x11-2.0 -lgdk-x11-2.0 -lpangocairo-1.0 -latk-1.0 -lcairo -lgdk_pixbuf-2.0 -lgio-2.0 -lpangoft2-1.0 -lpango-1.0 -lgobject-2.0 -lglib-2.0 -lintl -lharfbuzz -lfontconfig -lfreetype

> pkgconf --libs gtk+-3.0
-L/usr/local/lib -lgtk-3 -lgdk-3 -lpangocairo-1.0 -lpango-1.0 -lharfbuzz -latk-1.0 -lcairo-gobject -lcairo -lgdk_pixbuf-2.0 -lgio-2.0 -lgobject-2.0 -lglib-2.0 -lintl


IMO this is an issue with the GTK ports (it should not link all programs which use it with harfbuzz). In this case, should we still declare that this port depends on harfbuzz? I think not? The harfbuzz port is already depended (indirectly or directly) by gtk2 and gtk3 ports.
Comment 7 Nuno Teixeira freebsd_committer freebsd_triage 2022-08-30 10:39:07 UTC
(In reply to Henry Hu from comment #6)
Hi,

You have a point in here related to gtk and harfbuzz depends.
I also found, after a better look at logs, that poudriere testport OSVERSION: 1400066, didn't complain about harfbuzz lib dependecy.

I will commit and save this PR for comparison with other ports that have same issue to figure out what is causing this.

Thanks
Comment 8 commit-hook freebsd_committer freebsd_triage 2022-08-30 10:43:19 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=6e898ffb890ee4862fc5715f5fe885c8cc70b18b

commit 6e898ffb890ee4862fc5715f5fe885c8cc70b18b
Author:     Henry Hu <henry.hu.sh@gmail.com>
AuthorDate: 2022-08-30 10:40:46 +0000
Commit:     Nuno Teixeira <eduardo@FreeBSD.org>
CommitDate: 2022-08-30 10:42:27 +0000

    textproc/ibus: Update to 1.5.27

    ChangeLog:      https://github.com/ibus/ibus/releases/tag/1.5.27
    PR:             266090

 textproc/ibus/Makefile  | 8 ++++----
 textproc/ibus/distinfo  | 6 +++---
 textproc/ibus/pkg-plist | 4 +++-
 3 files changed, 10 insertions(+), 8 deletions(-)
Comment 9 Nuno Teixeira freebsd_committer freebsd_triage 2022-08-30 10:43:48 UTC
Committed, thanks!