Bug 266385 - textproc/libxml++: update to 5.0.2
Summary: textproc/libxml++: update to 5.0.2
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Fernando Apesteguía
URL: https://github.com/libxmlplusplus/lib...
Keywords: patch-ready
Depends on:
Blocks:
 
Reported: 2022-09-12 20:35 UTC by John Hein
Modified: 2022-09-13 18:57 UTC (History)
2 users (show)

See Also:


Attachments
[patch] update libxml++ to 5.0.2 (2.21 KB, patch)
2022-09-12 20:35 UTC, John Hein
jcfyecrayz: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description John Hein 2022-09-12 20:35:57 UTC
Created attachment 236520 [details]
[patch] update libxml++ to 5.0.2

Attached is an update to libxml++ 5.0.2

QA:
 poudriere testport: ok (12-stable/amd64)
 portclippy: ok
 portlint: ok


from NEWS:

5.0.2 (stable):

* Document, Node: Recognize HTML documents
  (Kjell Ahlstedt) Issue #23 (rkd77)
* Parsers: Avoid std::getline for istream inputs
  (Andrew Potter) Pull request #28
* Many small updates, suggested by the clang-tidy program
  (Rosen Penev) Pull requests #33-#35, #37-#43

Build:
* Meson build: When mm-common >= 1.0.4 is used, Perl is not required
  (Kjell Ahlstedt)
* Win32: Don't include afxres.h in resources
* Support Visual Studio 2022
  (Chun-wei Fan)
* Meson build: Specify 'check' option in run_command()
  Will be necessary with future versions of Meson.
  (Kjell Ahlstedt)
* Meson build: Avoid configuration warnings
  (Kjell Ahlstedt, Rosen Penev) Pull request #27
* docs/manual: Sort example file lists
  See https://gitlab.gnome.org/GNOME/gtkmm-documentation/-/merge_requests/15
  by Bernhard M. Wiedemann
  (Kjell Ahlstedt)
* Meson build: Enable static building on windows
  (Andrew Potter) Pull request #29
* Meson build: Require meson >= 0.60.0
* Meson build: libxml2 can be built as a subproject
  (Andrew Potter) Pull request #30
* NMake Makefiles: Remove dependency on msvc_recommended_pragmas.h
* NMake Makefiles: Make things more configurable
  (Chun-wei Fan) Issue #44 (lxxxd)

Documentation:
* docs/manual: Upgrade from DocBook 4.1 to DocBook 5.0
  (Kjell Ahlstedt)
* MSVC_NMake/README: Document dependency placement
  (Chun-wei Fan) Issue #44 (lxxxd)
Comment 1 Fernando Apesteguía freebsd_committer freebsd_triage 2022-09-13 06:56:21 UTC
^Triage: If there is a changelog or release notes URL available for this version, please add it to the URL field.

^Triage: Maintainer-feedback flag (+) not required unless requested (?) first.

Thanks!
Comment 2 Daniel Engberg freebsd_committer freebsd_triage 2022-09-13 08:50:10 UTC
Can you also try to upstream local patches if possible?

Best regards,
Daniel
Comment 3 commit-hook freebsd_committer freebsd_triage 2022-09-13 16:16:59 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=b90f428aece6ebf109a4807ce8a2f9518c26ffeb

commit b90f428aece6ebf109a4807ce8a2f9518c26ffeb
Author:     John Hein <jcfyecrayz@liamekaens.com>
AuthorDate: 2022-09-13 06:53:32 +0000
Commit:     Fernando Apesteguía <fernape@FreeBSD.org>
CommitDate: 2022-09-13 16:13:16 +0000

    textproc/libxml++: update to 5.0.2

    ChangeLog: https://github.com/libxmlplusplus/libxmlplusplus/releases/tag/5.0.2

    PR:             266385
    Reported by:    jcfyecrayz@liamekaens.com (maintainer)

 textproc/libxml++/Makefile                |  4 ++--
 textproc/libxml++/distinfo                |  6 +++---
 textproc/libxml++/files/patch-meson.build | 13 ++-----------
 textproc/libxml++/pkg-descr               |  2 ++
 4 files changed, 9 insertions(+), 16 deletions(-)
Comment 4 Fernando Apesteguía freebsd_committer freebsd_triage 2022-09-13 16:17:11 UTC
Committed,

Thanks!
Comment 5 John Hein 2022-09-13 18:57:42 UTC
(In reply to Daniel Engberg from comment #2)
The only patches are ones to install the *config.h header file in /usr/local/include instead of the upstream default of /usr/local/lib.

This (/include vs /lib) is a general FreeBSD preference, and is not likely a change upstream would accept, but we could attempt to convince upstream.  We could also change FreeBSD to accept the upstream default.

I am inclined to just keep the local patches for this unless it becomes a large enough headache.  Right now it's not, and the patches are minor.