Bug 266392 - net/ng_mikrotik_eoip: Fix build on recent 14.0
Summary: net/ng_mikrotik_eoip: Fix build on recent 14.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: gelraen.ua
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-09-13 08:02 UTC by John Baldwin
Modified: 2023-06-18 08:26 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (gelraen.ua)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description John Baldwin freebsd_committer freebsd_triage 2022-09-13 08:02:47 UTC 
This updates the port to work after I change I made in 14.0 a few months ago.  The patch is available for review at https://reviews.freebsd.org/D36545 (I didn't see an existing phab account for the port maintainer, so I'm also opening a PR).
Comment 1 Fernando Apesteguía freebsd_committer freebsd_triage 2022-09-14 06:05:38 UTC 
^Triage: Reporter is committer, assign accordingly.
Comment 2 commit-hook freebsd_committer freebsd_triage 2022-10-20 20:25:15 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=c9665e214f726d9a6e62af00d81b94567ebe2572

commit c9665e214f726d9a6e62af00d81b94567ebe2572
Author:     John Baldwin <jhb@FreeBSD.org>
AuthorDate: 2022-10-20 20:22:02 +0000
Commit:     John Baldwin <jhb@FreeBSD.org>
CommitDate: 2022-10-20 20:22:02 +0000

    net/ng_mikrotik_eoip: Fix build after recent changes in main.

    src commit 6d5f002ed1187547b0b40f8b46a3db38bf89c6dc changed the API of
    NG_NODE_FOREACH_HOOK to remove a mostly unused parameter.  Use a
    structure as the callback argument to save the returned hook.

    PR:             266392
    Differential Revision:  https://reviews.freebsd.org/D36545

 .../files/patch-ng__mikrotik__eoip.c (new)         | 60 ++++++++++++++++++++++
 1 file changed, 60 insertions(+)
Comment 3 commit-hook freebsd_committer freebsd_triage 2023-06-18 08:26:18 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=476e63e7b4e0f397ee2f371e0bd1ea75fb0a1758

commit 476e63e7b4e0f397ee2f371e0bd1ea75fb0a1758
Author:     Eugene Grosbein <eugen@FreeBSD.org>
AuthorDate: 2023-06-18 08:24:06 +0000
Commit:     Eugene Grosbein <eugen@FreeBSD.org>
CommitDate: 2023-06-18 08:25:34 +0000

    net/ng_mikrotik_eoip: unbreak build for FreeBSD before 14.0

    PR:             266392
    Fixes:          c9665e214f726d9a6e62af00d81b94567ebe2572

 net/ng_mikrotik_eoip/Makefile                         | 2 --
 net/ng_mikrotik_eoip/files/patch-ng__mikrotik__eoip.c | 2 +-
 2 files changed, 1 insertion(+), 3 deletions(-)