Bug 266401 - audio/kid3-qt5: Adjust dependencies
Summary: audio/kid3-qt5: Adjust dependencies
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Jason E. Hale
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-09-13 20:39 UTC by Daniel Engberg
Modified: 2022-09-14 03:48 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (jhale)

Attachments
Patch for kid3 (2.13 KB, patch)
2022-09-13 20:39 UTC, Daniel Engberg 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Engberg freebsd_committer freebsd_triage 2022-09-13 20:39:11 UTC 
Created attachment 236543 [details]
Patch for kid3

Remove unmaintained and redundant dependencies

Taglib can already handle all formats so no need for id3lib (upstream also recommends moving to taglib) and mp4v2

References:
https://invent.kde.org/multimedia/kid3/-/blob/v3.9.1/src/plugins/taglibmetadata/taglibfile.cpp#L556
https://sourceforge.net/projects/id3lib/
Comment 1 Daniel Engberg freebsd_committer freebsd_triage 2022-09-13 20:40:52 UTC 
bofh kindly test built first revision of this patch since my buildbox is swamped so it should be fine now (I adjusted pkg-plist according to error log).
Comment 2 commit-hook freebsd_committer freebsd_triage 2022-09-14 03:45:32 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=21dc3fef5f9680f44ba18f60b1993cf80e00ee46

commit 21dc3fef5f9680f44ba18f60b1993cf80e00ee46
Author:     Jason E. Hale <jhale@FreeBSD.org>
AuthorDate: 2022-09-14 03:37:35 +0000
Commit:     Jason E. Hale <jhale@FreeBSD.org>
CommitDate: 2022-09-14 03:37:35 +0000

    audio/kid3: Remove redundant dependencies

    Remove MP3, MP4, and TAGLIB options and make audio/taglib non-optional.
    audio/id3lib is unmaintained upstream and they recommend using taglib instead.
    Taglib can tag MP4 files, as well.
    PR:             266401
    Reported by:    diizzy

 audio/kid3/Makefile  | 27 +++++++++++----------------
 audio/kid3/pkg-plist |  4 +---
 2 files changed, 12 insertions(+), 19 deletions(-)
Comment 3 Jason E. Hale freebsd_committer freebsd_triage 2022-09-14 03:48:27 UTC 
I didn't notice this before I pushed my flavor update for kid3, but I have made the changes you suggested. Thanks!