Created attachment 236555 [details] new port diff The xdaliclock has been updated after a many years hiatus. The author decided to break a lot of old functionality. The new version: - doesn't support command line options - doesn't support custom fonts - doesn't support transparent background - has bugs with color settings - brings more dependencies I communicated with author and found him not caring about the lost features and myself not being able to make the new version look exactly like the old one did, hence existence of this port.
Hi Gleb, --- PORTNAME= xdaliclock PORTVERSION= 2.44 (...) PKGNAMESUFFIX= ${SUFFIX}-classic --- You using pkgname suffix like if it was an FLAVOR. Isn't: --- PORTNAME= xdaliclock-classic PORTVERSION= 2.44 --- the correct way? Don't know if a master/slave could be a good solution too. Cheers,
(In reply to Nuno Teixeira from comment #1) Thanks, Nuno! I don't know what is the right answer to this. If I knew, I would be a port committer and would commit that myself :) I believe you are right, this shouldn't be a FLAVOR, as the latter is same version compiled with different options. May I ask you to correct that and commit correct version?
(In reply to Gleb Smirnoff from comment #2) If latest 2.47 version supported Xlib and old funcionality, the best thing to use were flavors -xlib and -gtk. The problem is that upstream modified funtionality, dependncies, etc. In this case I suppose the best option is using 2.44 Xlib version as a new port -classic. Working on it. Cheers
(In reply to Gleb Smirnoff from comment #0) All set to commit. Just need a suitable commit msg, e.g.: --- The xdaliclock has been updated after a many years hiatus and lost important features like: - command line options support - custom fonts - transparent background xdaliclock-classic is an intent to keep historical features that are not present on recent updates. --- What do you think? Cheers
Sounds good to me! May be add one more point: - got heavier dependencies
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=50dd2bf4d46f2f9162075cf82b8d5dce27aab0dd commit 50dd2bf4d46f2f9162075cf82b8d5dce27aab0dd Author: Gleb Smirnoff <glebius@FreeBSD.org> AuthorDate: 2022-09-21 01:18:21 +0000 Commit: Nuno Teixeira <eduardo@FreeBSD.org> CommitDate: 2022-09-21 01:22:24 +0000 x11-clocks/xdaliclock-classic: New port: Rather neat animated clock (Xlib version) - Submitter becomes maintainer The xdaliclock has been updated after a many years hiatus, got heavier dependencies and lost important features like: - command line options support - custom fonts - transparent background xdaliclock-classic is an intent to keep historical features that are not present on recent updates. WWW: https://www.jwz.org/xdaliclock/ PR: 266414 x11-clocks/Makefile | 1 + x11-clocks/xdaliclock-classic/Makefile (new) | 21 +++++++++++++++++++++ x11-clocks/xdaliclock-classic/distinfo (new) | 3 +++ .../files/patch-Makefile.in (new) | 15 +++++++++++++++ x11-clocks/xdaliclock-classic/pkg-descr (new) | 3 +++ 5 files changed, 43 insertions(+)
Committed, thanks!
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=c8f6b65a2ba70b0b11fe7a2ca325559e1c6dde77 commit c8f6b65a2ba70b0b11fe7a2ca325559e1c6dde77 Author: Nuno Teixeira <eduardo@FreeBSD.org> AuthorDate: 2022-09-21 01:41:26 +0000 Commit: Nuno Teixeira <eduardo@FreeBSD.org> CommitDate: 2022-09-21 01:41:26 +0000 x11-clocks/xdaliclock-classic: Switch MASTER_SITES to https:// - switch MASTER_SITES to https:// (redirect) - Not bumping PORTREVISION PR: 266414 x11-clocks/xdaliclock-classic/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)