Bug 266421 - cad/calculix-ccx: update to 2.20
Summary: cad/calculix-ccx: update to 2.20
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Fernando Apesteguía
URL:
Keywords: needs-qa
Depends on:
Blocks:
 
Reported: 2022-09-15 07:55 UTC by rsmith
Modified: 2022-09-21 06:43 UTC (History)
1 user (show)

See Also:


Attachments
Patch to update the port to 2.20. (5.48 KB, patch)
2022-09-15 07:55 UTC, rsmith
rsmith: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description rsmith 2022-09-15 07:55:39 UTC
Created attachment 236562 [details]
Patch to update the port to 2.20.

Maintainer update to 2.20.
(update for cad/calculix will be posted separately.)

AFAICT, 2.20 produces the same results as 2.19 based on a sample of the input files that I've written.

I've replaced the compressed postscript manual with the PDF version to keep up with the times.
Comment 1 Fernando Apesteguía freebsd_committer freebsd_triage 2022-09-20 06:15:16 UTC
^Triage: If there is a changelog or release notes URL available for this version, please add it to the URL field.

^Triage: Please set the maintainer-approval attachment flag (to +) on patches for ports you maintain to signify approval.
--
Attachment -> Details -> maintainer-approval [+]

The patch includes a .gitignore file. I will just omit that.

Thanks!
Comment 2 Fernando Apesteguía freebsd_committer freebsd_triage 2022-09-20 11:57:37 UTC
There are issues with the port:
===> Checking for items in STAGEDIR missing from pkg-plist
Error: Orphaned: %%PORTDOCS%%%%DOCSDIR%%/ccx/img2620.png
Error: Orphaned: %%PORTDOCS%%%%DOCSDIR%%/ccx/img2621.png
Error: Orphaned: %%PORTDOCS%%%%DOCSDIR%%/ccx/img2622.png
Error: Orphaned: %%PORTDOCS%%%%DOCSDIR%%/ccx/img2623.png
Error: Orphaned: %%PORTDOCS%%%%DOCSDIR%%/ccx/img2624.png
Error: Orphaned: %%PORTDOCS%%%%DOCSDIR%%/ccx/img2625.png
Error: Orphaned: %%PORTDOCS%%%%DOCSDIR%%/ccx/img2626.png
Error: Orphaned: %%PORTDOCS%%%%DOCSDIR%%/ccx/img2627.png
Error: Orphaned: %%PORTDOCS%%%%DOCSDIR%%/ccx/img2628.png
Error: Orphaned: %%PORTDOCS%%%%DOCSDIR%%/ccx/img2629.png
Error: Orphaned: %%PORTDOCS%%%%DOCSDIR%%/ccx/img2630.png
Error: Orphaned: %%PORTDOCS%%%%DOCSDIR%%/ccx/img2631.png
Error: Orphaned: %%PORTDOCS%%%%DOCSDIR%%/ccx/img2632.png
Error: Orphaned: %%PORTDOCS%%%%DOCSDIR%%/ccx/img2633.png
Error: Orphaned: %%PORTDOCS%%%%DOCSDIR%%/ccx/img2634.png
Error: Orphaned: %%PORTDOCS%%%%DOCSDIR%%/ccx/img2635.png
Error: Orphaned: %%PORTDOCS%%%%DOCSDIR%%/ccx/img2636.png
Error: Orphaned: %%PORTDOCS%%%%DOCSDIR%%/ccx/img2637.png
Error: Orphaned: %%PORTDOCS%%%%DOCSDIR%%/ccx/img2638.png
Error: Orphaned: %%PORTDOCS%%%%DOCSDIR%%/ccx/img2639.png
Error: Orphaned: %%PORTDOCS%%%%DOCSDIR%%/ccx/img2640.png
Error: Orphaned: %%PORTDOCS%%%%DOCSDIR%%/ccx/img2641.png
Error: Orphaned: %%PORTDOCS%%%%DOCSDIR%%/ccx/img2642.png
Error: Orphaned: %%PORTDOCS%%%%DOCSDIR%%/ccx/img2643.png
Error: Orphaned: %%PORTDOCS%%%%DOCSDIR%%/ccx/img2644.png
Error: Orphaned: %%PORTDOCS%%%%DOCSDIR%%/ccx/img2645.png
Error: Orphaned: %%PORTDOCS%%%%DOCSDIR%%/ccx/img2646.png
Error: Orphaned: %%PORTDOCS%%%%DOCSDIR%%/ccx/img2647.png
Error: Orphaned: %%PORTDOCS%%%%DOCSDIR%%/ccx/img2648.png
Error: Orphaned: %%PORTDOCS%%%%DOCSDIR%%/ccx/img2649.png
Error: Orphaned: %%PORTDOCS%%%%DOCSDIR%%/ccx/img2650.png
Error: Orphaned: %%PORTDOCS%%%%DOCSDIR%%/ccx/img2651.png
Error: Orphaned: %%PORTDOCS%%%%DOCSDIR%%/ccx/img2652.png
Error: Orphaned: %%PORTDOCS%%%%DOCSDIR%%/ccx/img2653.png
Error: Orphaned: %%PORTDOCS%%%%DOCSDIR%%/ccx/img2654.png
Error: Orphaned: %%PORTDOCS%%%%DOCSDIR%%/ccx/img2655.png
Error: Orphaned: %%PORTDOCS%%%%DOCSDIR%%/ccx/img2656.png
Error: Orphaned: %%PORTDOCS%%%%DOCSDIR%%/ccx/img2657.png
Error: Orphaned: %%PORTDOCS%%%%DOCSDIR%%/ccx/img2658.png
Error: Orphaned: %%PORTDOCS%%%%DOCSDIR%%/ccx/img2659.png
Error: Orphaned: %%PORTDOCS%%%%DOCSDIR%%/ccx/img2660.png
Error: Orphaned: %%PORTDOCS%%%%DOCSDIR%%/ccx/img2661.png
Error: Orphaned: %%PORTDOCS%%%%DOCSDIR%%/ccx/img2662.png
Error: Orphaned: %%PORTDOCS%%%%DOCSDIR%%/ccx/img2663.png
Error: Orphaned: %%PORTDOCS%%%%DOCSDIR%%/ccx/img2664.png
Error: Orphaned: %%PORTDOCS%%%%DOCSDIR%%/ccx/img2665.png
...
...

Would you mind having a look?

Thanks!
Comment 3 Fernando Apesteguía freebsd_committer freebsd_triage 2022-09-20 15:39:50 UTC
Committed,

Please, use tools like poudriere to test the port :-)

Thanks!
Comment 4 commit-hook freebsd_committer freebsd_triage 2022-09-20 15:39:53 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=83fb668323dcea92548e91395f307d4262de4328

commit 83fb668323dcea92548e91395f307d4262de4328
Author:     Fernando Apesteguía <fernape@FreeBSD.org>
AuthorDate: 2022-09-20 06:10:19 +0000
Commit:     Fernando Apesteguía <fernape@FreeBSD.org>
CommitDate: 2022-09-20 15:36:08 +0000

    cad/calculix-ccx: update to 2.20

    PR:             266421
    Reported by:    rsmith@xs4all.nl

 cad/calculix-ccx/Makefile             |  13 +-
 cad/calculix-ccx/distinfo             |  18 +-
 cad/calculix-ccx/files/patch-Makefile |  17 +-
 cad/calculix-ccx/files/patch-date.pl  |   4 +-
 cad/calculix-ccx/pkg-plist            | 313 +++++++++++++++++++++++++++++++++-
 5 files changed, 338 insertions(+), 27 deletions(-)
Comment 5 rsmith 2022-09-20 17:26:36 UTC
(In reply to Fernando Apesteguía from comment #2)

What does "orphaned" mean?
Comment 6 rsmith 2022-09-20 17:38:08 UTC
(In reply to Fernando Apesteguía from comment #2)

Just checked my notes; I didn't run check-plist.
Will add it to my TODO.
Comment 7 Fernando Apesteguía freebsd_committer freebsd_triage 2022-09-21 06:41:14 UTC
(In reply to rsmith from comment #5)
It means those items are being installed, but they are not in pkg-plist and hence not recorded in the package metadata. That means that if we create a package like that, on uninstall, those files would be left behind.
Comment 8 Fernando Apesteguía freebsd_committer freebsd_triage 2022-09-21 06:43:05 UTC
(In reply to rsmith from comment #6)
That is why poudriere is so nice, it does all of that for you. And it checks the port in a clean environment so if dependencies change, it will tell you about it (the port will not build if any are missing).

Have a look at it. It is very easy to set up:
https://docs.freebsd.org/en/books/porters-handbook/testing/#testing-poudriere