Bug 266429 - net-im/libstrophe: Use upstream release archive and some fixes to Makefile
Summary: net-im/libstrophe: Use upstream release archive and some fixes to Makefile
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Ashish SHUKLA
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-09-15 20:09 UTC by Daniel Engberg
Modified: 2022-09-25 22:56 UTC (History)
0 users

See Also:
ashish: maintainer-feedback+

Attachments
Patch for libstrophe (1.72 KB, patch)
2022-09-15 20:09 UTC, Daniel Engberg 		no flags Details | Diff
Patch for libstrophe v2 (1.72 KB, patch)
2022-09-15 20:12 UTC, Daniel Engberg 		no flags Details | Diff
Patch for libstrophe v3 (1.71 KB, patch)
2022-09-15 21:32 UTC, Daniel Engberg 		no flags Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Engberg freebsd_committer freebsd_triage 2022-09-15 20:09:45 UTC 
Created attachment 236576 [details]
Patch for libstrophe

Use upstream release archive as recommended in USE_GITHUB section in Porters Handbook
Add option to use libxml2
Rearrange Makefile to follow Porters Handbook more closely

Compile tested on FreeBSD 13.1-STABLE #0 stable/13-n251817-0c4d13c521a (amd64) (make, make check-plist)
Comment 1 Daniel Engberg freebsd_committer freebsd_triage 2022-09-15 20:12:26 UTC 
Created attachment 236577 [details]
Patch for libstrophe v2

Upload correct patch
Comment 2 Daniel Engberg freebsd_committer freebsd_triage 2022-09-15 20:13:45 UTC 
We can probably drop the static library too?
Comment 3 Daniel Engberg freebsd_committer freebsd_triage 2022-09-15 21:32:41 UTC 
Created attachment 236580 [details]
Patch for libstrophe v3

Use framework naming for XML parsers
Comment 4 Ashish SHUKLA freebsd_committer freebsd_triage 2022-09-18 06:46:14 UTC 
The provided patch looks good to me. Please go ahead, and commit it at your convenience.

Thanks!
Comment 5 commit-hook freebsd_committer freebsd_triage 2022-09-25 22:50:32 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=a3557f38990dfe8b41ed37638bc89075360816f5

commit a3557f38990dfe8b41ed37638bc89075360816f5
Author:     Daniel Engberg <diizzy@FreeBSD.org>
AuthorDate: 2022-09-25 17:54:09 +0000
Commit:     Daniel Engberg <diizzy@FreeBSD.org>
CommitDate: 2022-09-25 22:46:47 +0000

    net-im/libstrophe: Use upstream release archive and improve port

    - Use upstream release archive as recommended in USE_GITHUB section
      in Porters Handbook
    - Add option to use libxml2
    - Rearrange Makefile to follow Porters Handbook more closely

    PR:             266429
    Reviewed by:    ashish (maintainer)

 net-im/libstrophe/Makefile | 25 +++++++++++++++++--------
 net-im/libstrophe/distinfo |  6 +++---
 2 files changed, 20 insertions(+), 11 deletions(-)