Bug 266467 - www/varnish7: Use upstream release archive and some improvements to Makefile
Summary: www/varnish7: Use upstream release archive and some improvements to Makefile
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Daniel Engberg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-09-17 20:36 UTC by Daniel Engberg
Modified: 2022-11-10 00:25 UTC (History)
0 users

See Also:
dbaio: maintainer-feedback+


Attachments
Patch for varnish (2.65 KB, patch)
2022-09-17 20:36 UTC, Daniel Engberg
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Engberg freebsd_committer freebsd_triage 2022-09-17 20:36:21 UTC
Created attachment 236645 [details]
Patch for varnish

- Use upstream release archive as recommended by USE_GITHUB section in Porters Handbook
- Remove USES= compiler as there's no need to modify configure script (compile tested with GCC 11)
- Remove unneeded gmake and readline dependency definition
- Use USES= localbase instead of CFLAGS variable
- Remove REINPLACE_CMD for gcc as it doesn't match anything
- Rearrange Makefile to follower Porters Handbook more closely and improve readability

Compile and runtime tested on FreeBSD 13.1-STABLE #0 stable/13-n251817-0c4d13c521a (amd64) (make, make check-plist, make test)
Poudriere testport OK 12.3-RELEASE (amd64)
Comment 1 Danilo G. Baio freebsd_committer freebsd_triage 2022-09-17 23:52:33 UTC
Thanks.
Please send the same to the other varnish ports... this one is a copy.
Comment 2 commit-hook freebsd_committer freebsd_triage 2022-10-16 21:23:56 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=efcf58c686899a38a58822afb4098b98c3d20e41

commit efcf58c686899a38a58822afb4098b98c3d20e41
Author:     Daniel Engberg <diizzy@FreeBSD.org>
AuthorDate: 2022-10-16 20:23:57 +0000
Commit:     Daniel Engberg <diizzy@FreeBSD.org>
CommitDate: 2022-10-16 21:22:48 +0000

    www/varnish7: Use upstream release archive and some improvements to port

    - Use upstream release archive as recommended by USE_GITHUB section
      in Porters Handbook
    - Remove USES= compiler as there's no need to modify configure script
    - Remove unneeded gmake and readline dependency definitions
    - Use USES= localbase instead of CFLAGS variable
    - Remove REINPLACE_CMD for GCC
    - Rearrange Makefile to follow Porters Handbook more closely and
      improve readability

    PR:             266467
    Reviewed by:    dbaio (maintainer)

 www/varnish7/Makefile | 42 ++++++++++++++++--------------------------
 www/varnish7/distinfo |  6 +++---
 2 files changed, 19 insertions(+), 29 deletions(-)
Comment 3 commit-hook freebsd_committer freebsd_triage 2022-11-10 00:25:32 UTC
A commit in branch 2022Q4 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=65541efda3e8345feaad76a84b2bfb37fce81f97

commit 65541efda3e8345feaad76a84b2bfb37fce81f97
Author:     Daniel Engberg <diizzy@FreeBSD.org>
AuthorDate: 2022-10-16 20:23:57 +0000
Commit:     Danilo G. Baio <dbaio@FreeBSD.org>
CommitDate: 2022-11-10 00:21:48 +0000

    www/varnish7: Use upstream release archive and some improvements to port

    - Use upstream release archive as recommended by USE_GITHUB section
      in Porters Handbook
    - Remove USES= compiler as there's no need to modify configure script
    - Remove unneeded gmake and readline dependency definitions
    - Use USES= localbase instead of CFLAGS variable
    - Remove REINPLACE_CMD for GCC
    - Rearrange Makefile to follow Porters Handbook more closely and
      improve readability

    PR:             266467
    Reviewed by:    dbaio (maintainer)

    (cherry picked from commit efcf58c686899a38a58822afb4098b98c3d20e41)

 www/varnish7/Makefile | 42 ++++++++++++++++--------------------------
 www/varnish7/distinfo |  6 +++---
 2 files changed, 19 insertions(+), 29 deletions(-)