Bug 266543 - net/tsclient:Fix build and remove BROKEN*: ld: error: duplicate symbol: gConnect
Summary: net/tsclient:Fix build and remove BROKEN*: ld: error: duplicate symbol: gConnect
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Fernando Apesteguía
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-09-22 05:08 UTC by NAKAJI Hiroyuki
Modified: 2022-09-24 16:43 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (ports)

Attachments
A patch to fix BROKEN (2.32 KB, patch)
2022-09-22 05:08 UTC, NAKAJI Hiroyuki 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description NAKAJI Hiroyuki 2022-09-22 05:08:48 UTC 
Created attachment 236743 [details]
A patch to fix BROKEN

net/tsclient cannot build with linker error on FreeBSD 13/14 and it is marked as BROKEN.
I made a patch to fix it.
It was successful to build it on FreeBSD/amd64 13.1-RELEASE-p2.
Comment 1 Fernando Apesteguía freebsd_committer freebsd_triage 2022-09-22 15:48:59 UTC 
Thanks for the patch!

Have you consider to send it upstream? This seems like something they would like to fix there :-)
Comment 2 commit-hook freebsd_committer freebsd_triage 2022-09-24 16:42:10 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=8c6fdee92af393f5b153e015fcf9b370e0818587

commit 8c6fdee92af393f5b153e015fcf9b370e0818587
Author:     NAKAJI Hiroyuki <nakaji@kankyo-u.ac.jp>
AuthorDate: 2022-09-22 15:44:11 +0000
Commit:     Fernando Apesteguía <fernape@FreeBSD.org>
CommitDate: 2022-09-24 16:37:35 +0000

    net/tsclient: Fix build

    Remove BROKEN*: ld: error: duplicate symbol: gConnect

    PR:             266543
    Reported by:    nakaji@kankyo-u.ac.jp
    Approved by:    ports@thepentagon.org (maintainer, timeout > 2 weeks)

 net/tsclient/Makefile                        |  3 ---
 net/tsclient/files/patch-src_connect.c (new) | 10 ++++++++++
 net/tsclient/files/patch-src_connect.h (new) | 11 +++++++++++
 net/tsclient/files/patch-src_main.c (new)    | 10 ++++++++++
 4 files changed, 31 insertions(+), 3 deletions(-)
Comment 3 Fernando Apesteguía freebsd_committer freebsd_triage 2022-09-24 16:43:22 UTC 
Committed,

Thanks!