Bug 266623 - security/nmap: Update to 7.93
Summary: security/nmap: Update to 7.93
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Cy Schubert
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-09-26 05:00 UTC by takefu
Modified: 2022-09-28 16:07 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (cy)


Attachments
nmap-7.93.patch (9.75 KB, patch)
2022-09-26 05:00 UTC, takefu
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 Cy Schubert freebsd_committer freebsd_triage 2022-09-27 01:47:55 UTC
This patch does more than simply update the port to 7.93. It adds LibreSSL support. I'll need to commit this in two separate commits in order to keep git history clean.

Now that we use GIT, it doesn't impose a penalty for each commit like SVN did. That penalty required committers to "batch" commits in order to keep repo bloat at a minimum. As repo bloat is no longer an issue with multiple commits, it is better to split commits into functional.

Additionally, it fails to build on 14-CURRENT. I'm out of office this week but will try to have a look at this next week.
Comment 2 Cy Schubert freebsd_committer freebsd_triage 2022-09-27 01:50:23 UTC
On second thought, rather than implement LibreSSL support in security/nmap, I'll consider creating a security/nmap-devel port that tracks the latest and greatest in their GH repo. Again, next week when I'm back.
Comment 3 Cy Schubert freebsd_committer freebsd_triage 2022-09-27 05:09:20 UTC
The problem is at line 71 of ncat_ssl.h. This is new code apparently for OpenSSL 3.0, which breaks using FreeBSD base ssl. Did you test this upgrade using base ssl or only with LibreSSL?
Comment 4 Cy Schubert freebsd_committer freebsd_triage 2022-09-28 15:43:27 UTC
Why this?

+CONFIGURE_ARGS+=--without-localdirs \
+		--without-zenmap \
+		--without-ndiff \
+		--with-libpcre=${LOCALBASE} \
+		--with-liblua=included \
+		--without-nmap-update

None of this was articulated in this PR.
Comment 5 commit-hook freebsd_committer freebsd_triage 2022-09-28 15:54:44 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=c98084fc137f5a45e08162123f0642ad626d7f74

commit c98084fc137f5a45e08162123f0642ad626d7f74
Author:     Cy Schubert <cy@FreeBSD.org>
AuthorDate: 2022-09-28 15:25:20 +0000
Commit:     Cy Schubert <cy@FreeBSD.org>
CommitDate: 2022-09-28 15:54:31 +0000

    security/nmap: Add LibreSSL support

    PR:             266623
    Submitted by:   takefu@airport.fm
    Reported by:    takefu@airport.fm

 security/nmap/files/patch-libssh2_src_openssl.h (new) | 14 ++++++++++++++
 security/nmap/files/patch-ncat__ncat_ssl.c (new)      | 13 +++++++++++++
 security/nmap/files/patch-nping_Crypto.cc (new)       | 13 +++++++++++++
 security/nmap/files/patch-nse__openssl.cc (new)       | 13 +++++++++++++
 security/nmap/files/patch-nse__ssl__cert.cc (new)     | 13 +++++++++++++
 5 files changed, 66 insertions(+)
Comment 6 commit-hook freebsd_committer freebsd_triage 2022-09-28 15:54:45 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=e5274f9c60037a3649382753b2370e6fea2e2b94

commit e5274f9c60037a3649382753b2370e6fea2e2b94
Author:     Cy Schubert <cy@FreeBSD.org>
AuthorDate: 2022-09-28 15:48:39 +0000
Commit:     Cy Schubert <cy@FreeBSD.org>
CommitDate: 2022-09-28 15:54:31 +0000

    security/nmap: Update to 7.93

    PR:             266623
    Reported by:    takefu@airport.fm

 security/nmap/Makefile                             |  3 +--
 security/nmap/distinfo                             |  6 +++---
 security/nmap/files/patch-libpcap_Makefile.in      |  8 +++++---
 .../nmap/files/patch-ncat_ncat__connect.c (gone)   | 23 ----------------------
 security/nmap/files/patch-ncat_ncat__ssl.h (new)   | 11 +++++++++++
 security/nmap/pkg-plist                            |  3 +++
 6 files changed, 23 insertions(+), 31 deletions(-)
Comment 7 Cy Schubert freebsd_committer freebsd_triage 2022-09-28 16:07:52 UTC
Updated and LibreSSL patches added.