Bug 266681 - sysutils/py-docker: Adopt/Update to 6.0.1
Summary: sysutils/py-docker: Adopt/Update to 6.0.1
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Nuno Teixeira
URL: https://github.com/docker/docker-py/c...
Keywords:
Depends on: 255722
Blocks:
  Show dependency treegraph
 
Reported: 2022-09-28 15:51 UTC by Norikatsu Shigemura
Modified: 2023-01-12 10:10 UTC (History)
2 users (show)

See Also:


Attachments
patch (1.80 KB, patch)
2022-09-28 15:51 UTC, Norikatsu Shigemura
no flags Details | Diff
patch (1.96 KB, patch)
2022-10-13 20:10 UTC, Norikatsu Shigemura
nork: maintainer-approval+
Details | Diff
patch (2.08 KB, patch)
2022-10-24 17:05 UTC, Norikatsu Shigemura
nork: maintainer-approval+
Details | Diff
Update to 6.0.1 (pep517) (2.17 KB, patch)
2023-01-11 10:08 UTC, Nuno Teixeira
eduardo: maintainer-approval? (nork)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Norikatsu Shigemura 2022-09-28 15:51:18 UTC
Created attachment 236917 [details]
patch

Update to 6.0.0
- portfmt happy.
- add support DOCKER_HOST via ssh://
- supported python: 3.7-3.10

ChangeLogs: https://github.com/docker/docker-py/releases/tag/6.0.0
Comment 1 Norikatsu Shigemura 2022-10-13 20:10:43 UTC
Created attachment 237277 [details]
patch

OK, I'll handle this port.
Comment 2 Nuno Teixeira freebsd_committer freebsd_triage 2022-10-20 21:30:34 UTC
Build fails at configure:
---
===>  Configuring for py39-docker-6.0.0
/usr/local/lib/python3.9/site-packages/setuptools/installer.py:27: SetuptoolsDeprecationWarning: setuptools.installer is deprecated. Requirements should be satisfied by a PEP 517 installer.
  warnings.warn(
WARNING: The wheel package is not available.
WARNING: Retrying (Retry(total=4, connect=None, read=None, redirect=None, status=None)) after connection broken by 'NewConnectionError('<pip._vendor.urllib3.connection.HTTPSConnection object
at 0x86c253b50>: Failed to establish a new connection: [Errno 8] Name does not resolve')': /simple/setuptools-scm/
---

Any clues?

Cheers
Comment 3 Norikatsu Shigemura 2022-10-24 17:05:55 UTC
Created attachment 237582 [details]
patch

Hummm...  I found a implicit dependency on py-wheel in .github/workflows/release.yml.
So I add a build-dependency on py-wheel.
Comment 4 Nuno Teixeira freebsd_committer freebsd_triage 2022-10-24 18:23:23 UTC
(In reply to Norikatsu Shigemura from comment #3)

---
Configuring for py39-docker-6.0.0
/usr/local/lib/python3.9/site-packages/setuptools/installer.py:27: SetuptoolsDeprecationWarning: setuptools.installer is deprecated. Requirements should be satisfied by a PEP 517 installer.
---

I think this is related to https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=255722

I will put this PR depending on PEP 517.
Comment 5 Nuno Teixeira freebsd_committer freebsd_triage 2023-01-11 08:17:07 UTC
Hello, finally PEP-517 support have landing!

Could you please send update to 6.0.1?
I will start testing new install method :)

Cheers
Comment 6 Nuno Teixeira freebsd_committer freebsd_triage 2023-01-11 10:08:06 UTC
Created attachment 239402 [details]
Update to 6.0.1 (pep517)

Checked pyproject.toml and add setuptools_acm (and wheel) to BUILD_DEPENDS

Could you please do a run test? It builds fine.

Cheers
Comment 7 Norikatsu Shigemura 2023-01-12 08:34:32 UTC
> Hello, finally PEP-517 support have landing!

WoW! That's good news!

> Could you please do a run test? It builds fine.

Sorry, in this time, I have no time to spend a run test.
So if you want to commit, please go ahead.
Comment 8 commit-hook freebsd_committer freebsd_triage 2023-01-12 10:04:01 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=8bd80665ccad01c95a2ffd078c8853c103901ca9

commit 8bd80665ccad01c95a2ffd078c8853c103901ca9
Author:     Norikatsu Shigemura <nork@ninth-nine.com>
AuthorDate: 2023-01-12 10:01:01 +0000
Commit:     Nuno Teixeira <eduardo@FreeBSD.org>
CommitDate: 2023-01-12 10:02:54 +0000

    sysutils/py-docker: Adopt/Update to 6.0.1

     - Submitter becomes maintainer
     - Switch to pep517 build

    ChangeLog:      https://github.com/docker/docker-py/compare/5.0.3...6.0.1
    PR:             266681

 sysutils/py-docker/Makefile | 21 ++++++++++++---------
 sysutils/py-docker/distinfo |  6 +++---
 2 files changed, 15 insertions(+), 12 deletions(-)
Comment 9 Nuno Teixeira freebsd_committer freebsd_triage 2023-01-12 10:10:40 UTC
- added build dependencies backends as described in pyproject.toml
- updated run dependencies versions as described in requirements.txt

- tests: I followed test-requirements.txt but I didn't make it to work, it seems that a network connection is needed (tested on a interactive poudriere jail)

Please re-open this PR if you receive any kind of problems.

Thanks for taking maintainership and updating port.

Committed!