Bug 266697 - databases/p5-Redis-Fast: Update to 0.34
Summary: databases/p5-Redis-Fast: Update to 0.34
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Nuno Teixeira
URL: https://metacpan.org/dist/Redis-Fast/...
Keywords:
Depends on:
Blocks:
 
Reported: 2022-09-29 08:34 UTC by Gian-Simon Purkert
Modified: 2022-10-04 14:50 UTC (History)
2 users (show)

See Also:
bokutin: maintainer-feedback+
eduardo: merge-quarterly+


Attachments
Update to 0.34 (887 bytes, patch)
2022-09-29 08:34 UTC, Gian-Simon Purkert
no flags Details | Diff
Update to 0.34 (1.10 KB, patch)
2022-10-02 13:16 UTC, Gian-Simon Purkert
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gian-Simon Purkert 2022-09-29 08:34:49 UTC
Created attachment 236936 [details]
Update to 0.34
Comment 1 Tomohiro Hosaka 2022-09-29 09:04:40 UTC
Thanks for the update.
I have confirmed that there is no problem in my environment.
Comment 2 Gian-Simon Purkert 2022-10-02 13:16:01 UTC
Created attachment 237012 [details]
Update to 0.34

Change to Distversion and License to ARTPERL10
Comment 3 Tomohiro Hosaka 2022-10-03 00:24:51 UTC
Thanks also about LICENCE.
I have confirmed that there is no problem.

( Is there anything else yet to do as MAINTENAR? )
Comment 4 Gian-Simon Purkert 2022-10-03 07:08:32 UTC
(In reply to Tomohiro Hosaka from comment #3)

Right from the Attachment is "Details" there you can find maintainer-approval, if your ok with the patch please set it to "+", then submit.

Thanks and have a great Day,

Gian-Simon
Comment 5 Tomohiro Hosaka 2022-10-03 07:16:04 UTC
Comment on attachment 237012 [details]
Update to 0.34

I have confirmed that there is no problem.
Comment 6 Tomohiro Hosaka 2022-10-03 07:19:41 UTC
Comment on attachment 237012 [details]
Update to 0.34

I want to set the flag to "+".
Comment 7 Tomohiro Hosaka 2022-10-03 07:21:23 UTC
Comment on attachment 237012 [details]
Update to 0.34

Flag is "+" and not saved. Sorry.
Comment 8 Nuno Teixeira freebsd_committer freebsd_triage 2022-10-04 12:15:02 UTC
`portlint -C`:
WARN: Makefile: dependency to gmake listed in BUILD_DEPENDS. consider using USES[+]=gmake.

Thanks
Comment 10 Gian-Simon Purkert 2022-10-04 13:23:49 UTC
(In reply to Nuno Teixeira from comment #8)

If i add USES= gmake perl i get that a compile error.

With "just":

BUILD_DEPENDS=  p5-File-Which>=0:sysutils/p5-File-Which \
                p5-Module-Build-XSUtil>=0.02:devel/p5-Module-Build-XSUtil \
                gmake:devel/gmake

It builds.
Comment 11 Gian-Simon Purkert 2022-10-04 13:41:59 UTC
(In reply to Nuno Teixeira from comment #8)

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=250796#c5
Comment 12 Gian-Simon Purkert 2022-10-04 13:43:07 UTC
>> Fernando Apesteguía freebsd_committer 2020-11-20 19:32:40 UTC

Hi Tomohiro,

I had a look and I think it is a false positive from portlint.

The port needs gmake to build the hiredis dependency but then it uses modbuild to build itself. If we do USES=gmake, gmake will be tried to build the port and that is not what we want. We want it to build with modbuild.

I think we are good to go as it is.
Comment 13 Nuno Teixeira freebsd_committer freebsd_triage 2022-10-04 14:22:50 UTC
(In reply to Gian-Simon Purkert from comment #12)

Yes, you're right.
Sorry for the noise.
Comment 14 commit-hook freebsd_committer freebsd_triage 2022-10-04 14:41:09 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=bc658e05d58f97aa331b1e22af247973db6168d0

commit bc658e05d58f97aa331b1e22af247973db6168d0
Author:     Gian-Simon Purkert <gspurki@gmail.com>
AuthorDate: 2022-10-04 14:36:34 +0000
Commit:     Nuno Teixeira <eduardo@FreeBSD.org>
CommitDate: 2022-10-04 14:40:02 +0000

    databases/p5-Redis-Fast: Update to 0.34

     - Switch to DISTVERSION
     - Use ARTPERL10 instead of ART10 license

    ChangeLog:      https://metacpan.org/dist/Redis-Fast/changes
    PR:             266697
    MFH:            2022Q4

 databases/p5-Redis-Fast/Makefile | 4 ++--
 databases/p5-Redis-Fast/distinfo | 6 +++---
 2 files changed, 5 insertions(+), 5 deletions(-)
Comment 15 commit-hook freebsd_committer freebsd_triage 2022-10-04 14:49:12 UTC
A commit in branch 2022Q4 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=bf2f0e3bf9c2b68ed2361ce50ebcb1ccb337c08d

commit bf2f0e3bf9c2b68ed2361ce50ebcb1ccb337c08d
Author:     Gian-Simon Purkert <gspurki@gmail.com>
AuthorDate: 2022-10-04 14:36:34 +0000
Commit:     Nuno Teixeira <eduardo@FreeBSD.org>
CommitDate: 2022-10-04 14:41:57 +0000

    databases/p5-Redis-Fast: Update to 0.34

     - Switch to DISTVERSION
     - Use ARTPERL10 instead of ART10 license

    ChangeLog:      https://metacpan.org/dist/Redis-Fast/changes
    PR:             266697
    MFH:            2022Q4
    (cherry picked from commit bc658e05d58f97aa331b1e22af247973db6168d0)

 databases/p5-Redis-Fast/Makefile | 4 ++--
 databases/p5-Redis-Fast/distinfo | 6 +++---
 2 files changed, 5 insertions(+), 5 deletions(-)
Comment 16 Nuno Teixeira freebsd_committer freebsd_triage 2022-10-04 14:50:12 UTC
Committed, thanks!