Bug 266725 - security/gvm-libs: fix build on armv7
Summary: security/gvm-libs: fix build on armv7
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: arm Any
: --- Affects Only Me
Assignee: Jose Alonso Cardenas Marquez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-09-30 14:07 UTC by Robert Clausecker
Modified: 2022-10-15 14:39 UTC (History)
2 users (show)

See Also:
fuz: maintainer-feedback-
fuz: merge-quarterly?

Attachments
security/gvm-libs: fix build on armv7 (4.79 KB, patch)
2022-09-30 14:07 UTC, Robert Clausecker 		fuz: maintainer-approval+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Clausecker freebsd_committer freebsd_triage 2022-09-30 14:07:06 UTC 
Created attachment 236970 [details]
security/gvm-libs: fix build on armv7

- add missing type casts for sizeof(time_t) > sizeof(long)
 - neuter -Werror as per policy
 - while we are at it, pet portlint

Tested with Poudriere on armv7 arm64 FreeBSD 13.1.
Test suite cannot be run due to unported test dependency (hence not hooked up either).
Please MFH if committed after 2022Q4 is branched off.
Comment 1 Robert Clausecker freebsd_committer freebsd_triage 2022-10-15 13:00:01 UTC 
maintainer timeout
Comment 2 Robert Clausecker freebsd_committer freebsd_triage 2022-10-15 13:00:32 UTC 
Comment on attachment 236970 [details]
security/gvm-libs: fix build on armv7

maintainer timeout on patch
Comment 3 commit-hook freebsd_committer freebsd_triage 2022-10-15 14:37:27 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=a774bfbbb08cf1c3529696f9ddc205ca460a6743

commit a774bfbbb08cf1c3529696f9ddc205ca460a6743
Author:     Robert Clausecker <fuz@fuz.su>
AuthorDate: 2022-09-30 09:35:56 +0000
Commit:     Dima Panov <fluffy@FreeBSD.org>
CommitDate: 2022-10-15 14:34:16 +0000

    security/gvm-libs: fix build on armv7 (+)

     - add missing type casts for sizeof(time_t) > sizeof(long)
     - neuter -Werror as per policy
     - while we are at it, pet portlint

    Approved by:    maintainer timeout (acm)
    Submitted by:   Robert Clausecker
    PR:             266725
    MFH:            2022Q4

 security/gvm-libs/Makefile                           |  7 +++----
 security/gvm-libs/files/patch-CMakeLists.txt         | 20 ++++++++++++++------
 .../gvm-libs/files/patch-boreas_alivedetection.c     | 15 +++++++++++++--
 security/gvm-libs/files/patch-boreas_cli.c (new)     | 13 +++++++++++++
 4 files changed, 43 insertions(+), 12 deletions(-)
Comment 4 commit-hook freebsd_committer freebsd_triage 2022-10-15 14:38:28 UTC 
A commit in branch 2022Q4 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=e4b4b252c8b3ed0b7afb4b17a28ae8bfa8d79027

commit e4b4b252c8b3ed0b7afb4b17a28ae8bfa8d79027
Author:     Robert Clausecker <fuz@fuz.su>
AuthorDate: 2022-09-30 09:35:56 +0000
Commit:     Dima Panov <fluffy@FreeBSD.org>
CommitDate: 2022-10-15 14:37:26 +0000

    security/gvm-libs: fix build on armv7 (+)

     - add missing type casts for sizeof(time_t) > sizeof(long)
     - neuter -Werror as per policy
     - while we are at it, pet portlint

    Approved by:    maintainer timeout (acm)
    Submitted by:   Robert Clausecker
    PR:             266725
    MFH:            2022Q4

    (cherry picked from commit a774bfbbb08cf1c3529696f9ddc205ca460a6743)

 security/gvm-libs/Makefile                           |  7 +++----
 security/gvm-libs/files/patch-CMakeLists.txt         | 20 ++++++++++++++------
 .../gvm-libs/files/patch-boreas_alivedetection.c     | 15 +++++++++++++--
 security/gvm-libs/files/patch-boreas_cli.c (new)     | 13 +++++++++++++
 4 files changed, 43 insertions(+), 12 deletions(-)
Comment 5 Dima Panov freebsd_committer freebsd_triage 2022-10-15 14:39:28 UTC 
Committed and MFHed, thanks!