Bug 266729 - security/john: fix build on armv7
Summary: security/john: fix build on armv7
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: arm Any
: --- Affects Only Me
Assignee: Alexey Dokuchaev
URL: https://github.com/openwall/john/comm...
Keywords:
Depends on:
Blocks:
 
Reported: 2022-09-30 16:32 UTC by Robert Clausecker
Modified: 2022-09-30 19:14 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (danfe)

Attachments
security/john: fix build on armv7 (2.18 KB, patch)
2022-09-30 16:32 UTC, Robert Clausecker 		fuz: maintainer-approval? (danfe)
 Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Clausecker freebsd_committer freebsd_triage 2022-09-30 16:32:25 UTC 
Created attachment 236973 [details]
security/john: fix build on armv7

This change applies an upstream patch, fixing AArch32 NEON intrinsics in the port.

Tested on armv7 FreeBSD 13.1.
Please MFH if committed after 2022Q4 is branched off.
Comment 1 commit-hook freebsd_committer freebsd_triage 2022-09-30 18:12:55 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=5c648bf25f56ca85cf4bbc21cc2ec3fb7ffbdc77

commit 5c648bf25f56ca85cf4bbc21cc2ec3fb7ffbdc77
Author:     Alexey Dokuchaev <danfe@FreeBSD.org>
AuthorDate: 2022-09-30 18:11:46 +0000
Commit:     Alexey Dokuchaev <danfe@FreeBSD.org>
CommitDate: 2022-09-30 18:11:46 +0000

    security/john: attempt to fix the build on armv7

    This is from upstream commit c9825e6 which improves
    ARM pseudo-intrinsics portability.

    PR:             266729
    Submitted by:   Robert Clausecker

 security/john/files/patch-pseudo__intrinsics.h (new) | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)
Comment 2 Alexey Dokuchaev freebsd_committer freebsd_triage 2022-09-30 18:19:00 UTC 
Committed, thanks!  Since it was just one file, I've opted to standard path-based patch name rather than embedding commit hash in it (but mentioned in the log).
Comment 3 Robert Clausecker freebsd_committer freebsd_triage 2022-09-30 19:14:51 UTC 
AArch64 still fails, will investigate that one next.