Bug 266790 - multimedia/py-soco: Update to 0.28
Summary: multimedia/py-soco: Update to 0.28
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Nuno Teixeira
URL: https://github.com/SoCo/SoCo/releases...
Keywords:
Depends on:
Blocks:
 
Reported: 2022-10-03 13:38 UTC by Gian-Simon Purkert
Modified: 2022-10-05 13:50 UTC (History)
2 users (show)

See Also:
conall: maintainer-feedback+

Attachments
Update to 0.28 (898 bytes, patch)
2022-10-03 13:38 UTC, Gian-Simon Purkert 		no flags Details | Diff
py39-soco-0.28.0 v1 (1.99 KB, patch)
2022-10-05 09:42 UTC, Nuno Teixeira 		conall: maintainer-approval+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gian-Simon Purkert 2022-10-03 13:38:14 UTC 
Created attachment 237047 [details]
Update to 0.28
Comment 1 Conall O'Brien 2022-10-04 09:45:48 UTC 
Thank you very much! I had missed this release
Comment 2 Nuno Teixeira freebsd_committer freebsd_triage 2022-10-04 11:57:46 UTC 
testunit fails:
---
ImportError while loading conftest '/wrkdirs/usr/ports/multimedia/py-soco/work-py39/SoCo-0.28.0/tests/conftest.py'.
tests/conftest.py:12: in <module>
    from soco import SoCo
soco/__init__.py:12: in <module>
    from .core import SoCo
soco/core.py:55: in <module>
    from .zonegroupstate import ZoneGroupState
soco/zonegroupstate.py:66: in <module>
    from lxml import etree as LXML
E   ModuleNotFoundError: No module named 'lxml'
---

Ant clues?

Thanks
Comment 3 Conall O'Brien 2022-10-04 12:11:17 UTC 
According to the release notes, lxml is a new dependency.


We should add devel/py-lxml as a dependency
Comment 4 Nuno Teixeira freebsd_committer freebsd_triage 2022-10-05 09:42:31 UTC 
Created attachment 237095 [details]
py39-soco-0.28.0 v1

 - Switch to DISTVERSION
 - Add devel/py-lxml dependency
 - pet portlint, portclippy and portfmt

testunit: OK
Comment 5 Nuno Teixeira freebsd_committer freebsd_triage 2022-10-05 09:46:02 UTC 
(In reply to Nuno Teixeira from comment #4)
(...)

 - Use USES=python instead of python:3.6+ since avilable version are 3.9
   and eoled 2.7
Comment 6 Conall O'Brien 2022-10-05 13:14:38 UTC 
Comment on attachment 237095 [details]
py39-soco-0.28.0 v1

Maintainer approves
Comment 7 commit-hook freebsd_committer freebsd_triage 2022-10-05 13:50:27 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=fccdf345e932452f7f3c354eceddabae8b0f77d7

commit fccdf345e932452f7f3c354eceddabae8b0f77d7
Author:     Gian-Simon Purkert <gspurki@gmail.com>
AuthorDate: 2022-10-05 13:47:43 +0000
Commit:     Nuno Teixeira <eduardo@FreeBSD.org>
CommitDate: 2022-10-05 13:49:43 +0000

    multimedia/py-soco: Update to 0.28

    ChangeLog:      https://github.com/SoCo/SoCo/releases/tag/v0.28.0
    PR:             266790

 multimedia/py-soco/Makefile | 16 ++++++++--------
 multimedia/py-soco/distinfo |  6 +++---
 2 files changed, 11 insertions(+), 11 deletions(-)
Comment 8 Nuno Teixeira freebsd_committer freebsd_triage 2022-10-05 13:50:52 UTC 
Committed, thanks!