Bug 266796 - security/openvpn: make use of "name_FLAGS"
Summary: security/openvpn: make use of "name_FLAGS"
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: amd64 Any
: --- Affects Some People
Assignee: Matthias Andree
URL:
Keywords:
: 266820 (view as bug list)
Depends on:
Blocks: 266820
  Show dependency tree / graph
 
Reported: 2022-10-03 16:30 UTC by 0x1eef
Modified: 2022-10-05 19:11 UTC (History)
2 users (show)

See Also:
mandree: maintainer-feedback+

Attachments
A diff that makes use of name_FLAGS. (762 bytes, patch)
2022-10-03 16:30 UTC, 0x1eef 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description 0x1eef 2022-10-03 16:30:03 UTC 
Created attachment 237054 [details]
A diff that makes use of name_FLAGS.

Hi !

I noticed and tried to use the "name_FLAGS" option but it had no effect. Attached is a simple diff that makes use of "name_FLAGS". Thanks!
Comment 1 Matthias Andree freebsd_committer freebsd_triage 2022-10-03 20:16:41 UTC 
Hi 0x1eef,

thanks for your submission, which has been committed.
Comment 2 commit-hook freebsd_committer freebsd_triage 2022-10-03 20:16:43 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=29d16aeb4442994cf93d26084e4b79ff55d3feba

commit 29d16aeb4442994cf93d26084e4b79ff55d3feba
Author:     0x1eef <0x1eef@protonmail.com>
AuthorDate: 2022-10-03 20:14:30 +0000
Commit:     Matthias Andree <mandree@FreeBSD.org>
CommitDate: 2022-10-03 20:15:41 +0000

    security/openvpn: support ${name}_FLAGS

    and bump PORTREVISION.

    PR:             266796

 security/openvpn/Makefile         | 2 +-
 security/openvpn/files/openvpn.in | 3 ++-
 2 files changed, 3 insertions(+), 2 deletions(-)
Comment 3 commit-hook freebsd_committer freebsd_triage 2022-10-03 20:48:48 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=b098de65c55ca375bc64a587541f9a81b8975b8f

commit b098de65c55ca375bc64a587541f9a81b8975b8f
Author:     Matthias Andree <mandree@FreeBSD.org>
AuthorDate: 2022-10-03 20:45:46 +0000
Commit:     Matthias Andree <mandree@FreeBSD.org>
CommitDate: 2022-10-03 20:45:46 +0000

    devel/py-llfuse: reset maintainer, unreachable

    This appears, per INDEX-13, to be the only port where
    MAINTAINER was set to stdin@niklaas.eu.

    PR:             266796

    --------------------
    Reporting-MTA: dns; mx2.freebsd.org
    X-Postfix-Queue-ID: 4MhC8t64n8z3YDm
    X-Postfix-Sender: rfc822; mandree@FreeBSD.org
    Arrival-Date: Mon,  3 Oct 2022 20:28:46 +0000 (UTC)

    Final-Recipient: rfc822; stdin@niklaas.eu
    Original-Recipient: rfc822;stdin@niklaas.eu
    Action: failed
    Status: 5.1.1
    Remote-MTA: dns; mx02.mail.icloud.com
    Diagnostic-Code: smtp; 550 5.1.1 <stdin@niklaas.eu>: user does not exist
    --------------------

 devel/py-llfuse/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 4 Matthias Andree freebsd_committer freebsd_triage 2022-10-03 21:01:27 UTC 
(In reply to commit-hook from comment #3)
disregard this comment #3, it was meant for https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=266201
Comment 5 Vladimir Druzenko freebsd_committer freebsd_triage 2022-10-04 02:49:31 UTC 
Broken start script for openvpn after this commit: https://cgit.freebsd.org/ports/commit/?id=29d16aeb4442994cf93d26084e4b79ff55d3feba
Fix:
-flags="$(eval echo \${$name}_flags})"
+flags="$(eval echo \${${name}_flags})"
Comment 6 commit-hook freebsd_committer freebsd_triage 2022-10-04 06:22:04 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=ae6cc1b955c9ece4d45071ce6a80d6a8ff01c524

commit ae6cc1b955c9ece4d45071ce6a80d6a8ff01c524
Author:     VVD <vvd@unislabs.com>
AuthorDate: 2022-10-04 06:20:03 +0000
Commit:     Matthias Andree <mandree@FreeBSD.org>
CommitDate: 2022-10-04 06:20:50 +0000

    security/openvpn: fix up ${name}_flags option

    was broken in previous commit; bumping PORTREVISION again

    PR:             266796

 security/openvpn/Makefile         | 2 +-
 security/openvpn/files/openvpn.in | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
Comment 7 0x1eef 2022-10-04 11:54:57 UTC 
My apologies ! I should have been more careful when preparing this patch. Thanks for the quick fix.
Comment 8 Matthias Andree freebsd_committer freebsd_triage 2022-10-05 19:11:39 UTC 
*** Bug 266820 has been marked as a duplicate of this bug. ***