Bug 266936 - graphics/wayland-protocols: update to 1.27
Summary: graphics/wayland-protocols: update to 1.27
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-x11 (Nobody)
URL: https://lists.freedesktop.org/archive...
Keywords: patch, patch-ready
Depends on:
Blocks:
 
Reported: 2022-10-10 08:53 UTC by Jan Beich
Modified: 2022-10-10 11:48 UTC (History)
1 user (show)

See Also:
manu: maintainer-feedback+


Attachments
v1 (apply via "git am") (2.39 KB, patch)
2022-10-10 08:53 UTC, Jan Beich
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Beich freebsd_committer freebsd_triage 2022-10-10 08:53:22 UTC
Created attachment 237184 [details]
v1 (apply via "git am")
Comment 2 Emmanuel Vadot freebsd_committer freebsd_triage 2022-10-10 09:07:31 UTC
Shouldn't we bump ports depending on this too ?
Otherwise we will have difference between packages installed and the one on the server.
Comment 3 Jan Beich freebsd_committer freebsd_triage 2022-10-10 09:24:41 UTC
(In reply to Jan Beich from comment #1)
Required by https://gitlab.freedesktop.org/wlroots/wlroots/-/merge_requests/3599 (content-type-v1)

(In reply to Emmanuel Vadot from comment #2)
> Shouldn't we bump ports depending on this too ?

No. wayland-protocols has no ABI (consumers check version at build time), 1.27 doesn't change existing features while old consumers are very unlikely to use brand new features (that didn't exist back then).

Regressions usually come from compositor upgrades e.g., when wlroots bumps version of one of the protocols while clients blindly bind to latest only to trip on semantic changes..

> Otherwise we will have difference between packages installed and the one on the server.

I don't understand what you mean.
Comment 4 Emmanuel Vadot freebsd_committer freebsd_triage 2022-10-10 09:39:22 UTC
(In reply to Jan Beich from comment #3)

If the version is checked at build time this will do :

- You update the port
- Package builder start for CURRENT and __FreeBSD_version was bumped so a poudriere bulk -c is done
- This result in having sway (or any other compositor) built with 1.27
- I still have sway locally with the same version as in the repo but built with 1.26

Even if this version doesn't change existing features this result in different packages produced (unless compositor never store the wayland-protocol version somewhere, which could be the case I haven't checked).
Comment 5 Jan Beich freebsd_committer freebsd_triage 2022-10-10 11:01:25 UTC
(In reply to Emmanuel Vadot from comment #4)
> Even if this version doesn't change existing features this result in different packages...

sha256 libwlroots.so and "sway" binary (until review D24586 whole packages may still differ in minor ways) output didn't change after wayland-protocols 1.26 -> 1.27. sway doesn't have extra protocols on top of wlroots unlike wayfire or river. Not packaged protocols[1] are usually bundled e.g.,

https://github.com/WayfireWM/wayfire/blob/master/proto/wayfire-shell-unstable-v2.xml
https://github.com/WayfireWM/wf-shell/blob/master/proto/wayfire-shell-unstable-v2.xml

https://github.com/riverwm/river/blob/master/protocol/river-status-unstable-v1.xml
https://github.com/Alexays/Waybar/blob/master/protocol/river-status-unstable-v1.xml

https://gitlab.freedesktop.org/wlroots/wlroots/-/blob/master/protocol/wlr-layer-shell-unstable-v1.xml
https://github.com/swaywm/sway/blob/master/protocols/wlr-layer-shell-unstable-v1.xml
https://invent.kde.org/plasma/kwayland-server/-/blob/master/src/protocols/wlr-layer-shell-unstable-v1.xml
https://github.com/MirServer/mir/blob/main/src/wayland/protocol/wlr-layer-shell-unstable-v1.xml
https://github.com/emersion/slurp/blob/master/protocol/wlr-layer-shell-unstable-v1.xml

Except GNOME which prefers throwing Wayland under DBus

https://gitlab.gnome.org/GNOME/mutter/-/tree/main/data/dbus-interfaces/
https://blogs.kde.org/2020/10/11/linux-desktop-shell-ipc-wayland-vs-d-bus-and-lack-agreement-when-use-them

Individual protocols are versioned, so the version of a collection (e.g., wayland-protocols, plasma-wayland-protocols) rarely matters except for simplifying build system when unbundling. For example, wlr-protocols doesn't have a version despite being a collection.
Comment 6 Emmanuel Vadot freebsd_committer freebsd_triage 2022-10-10 11:12:08 UTC
(In reply to Jan Beich from comment #5)

Ok, good for me then.
Comment 7 commit-hook freebsd_committer freebsd_triage 2022-10-10 11:35:26 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=13a88fcede1867dd1fa9e9a76d057a51170046a7

commit 13a88fcede1867dd1fa9e9a76d057a51170046a7
Author:     Jan Beich <jbeich@FreeBSD.org>
AuthorDate: 2022-10-10 08:20:28 +0000
Commit:     Jan Beich <jbeich@FreeBSD.org>
CommitDate: 2022-10-10 11:23:59 +0000

    graphics/wayland-protocols: update to 1.27

    Changes:        https://lists.freedesktop.org/archives/wayland-devel/2022-October/042466.html
    PR:             266936
    Reported by:    GitLab (notify releases)
    Approved by:    manu

 graphics/wayland-protocols/Makefile  | 4 ++--
 graphics/wayland-protocols/distinfo  | 6 +++---
 graphics/wayland-protocols/pkg-plist | 2 ++
 3 files changed, 7 insertions(+), 5 deletions(-)