Bug 266955 - security/libpki: fix build on armv7 and arm64
Summary: security/libpki: fix build on armv7 and arm64
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: arm Any
: --- Affects Only Me
Assignee: Nuno Teixeira
URL: https://github.com/openca/libpki/issu...
Keywords:
Depends on:
Blocks:
 
Reported: 2022-10-10 20:05 UTC by Robert Clausecker
Modified: 2022-10-15 16:25 UTC (History)
2 users (show)

See Also:
bruno: maintainer-feedback+
eduardo: merge-quarterly+


Attachments
security/libpki: fix build on armv7 and arm64 (1.35 KB, patch)
2022-10-10 20:05 UTC, Robert Clausecker
fuz: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Clausecker freebsd_committer freebsd_triage 2022-10-10 20:05:35 UTC
Created attachment 237201 [details]
security/libpki: fix build on armv7 and arm64

- add case for armv7 to configure script
- adapt aarch64 case to arm64
- while we are at it, hook up test suite

Tested with Poudriere on armv7 arm64 FreeBSD 13.1.
The test suite passes except for tests 6, 8, and 9 which fail on both.
Comment 1 Bruno Damour 2022-10-15 13:06:08 UTC
Hello,
Thanks for this submission, I myself cannot test on arm, but this seems OK to me.
IMHO we should make a PR upstream.
Bruno
Comment 2 Robert Clausecker freebsd_committer freebsd_triage 2022-10-15 15:19:47 UTC
(In reply to Bruno Damour from comment #1)

Have already done so (please see URL).
Comment 3 Robert Clausecker freebsd_committer freebsd_triage 2022-10-15 15:20:42 UTC
Comment on attachment 237201 [details]
security/libpki: fix build on armv7 and arm64

Set maintainer-approval as per comment #1.
Comment 4 commit-hook freebsd_committer freebsd_triage 2022-10-15 16:21:47 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=e5a5d9c7275237e116c0a5bf7a7c8436c0db061b

commit e5a5d9c7275237e116c0a5bf7a7c8436c0db061b
Author:     Robert Clausecker <fuz@fuz.su>
AuthorDate: 2022-10-15 16:17:47 +0000
Commit:     Nuno Teixeira <eduardo@FreeBSD.org>
CommitDate: 2022-10-15 16:21:01 +0000

    security/libpki: Fix build on armv7 and arm64

    - add case for armv7 to configure script
    - adapt aarch64 case to arm64
      https://github.com/openca/libpki/issues/57
    - while we are at it, hook up test suite
    - bump PORTREVISION

    PR:             266955
    MFH:            2022Q4

 security/libpki/Makefile                       |  5 ++---
 security/libpki/files/patch-configure.ac (new) | 13 +++++++++++++
 2 files changed, 15 insertions(+), 3 deletions(-)
Comment 5 commit-hook freebsd_committer freebsd_triage 2022-10-15 16:24:49 UTC
A commit in branch 2022Q4 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=fae3c318a10e6fc9870fd1f2a41611ceafe11cc4

commit fae3c318a10e6fc9870fd1f2a41611ceafe11cc4
Author:     Robert Clausecker <fuz@fuz.su>
AuthorDate: 2022-10-15 16:17:47 +0000
Commit:     Nuno Teixeira <eduardo@FreeBSD.org>
CommitDate: 2022-10-15 16:22:00 +0000

    security/libpki: Fix build on armv7 and arm64

    - add case for armv7 to configure script
    - adapt aarch64 case to arm64
      https://github.com/openca/libpki/issues/57
    - while we are at it, hook up test suite
    - bump PORTREVISION

    PR:             266955
    MFH:            2022Q4
    (cherry picked from commit e5a5d9c7275237e116c0a5bf7a7c8436c0db061b)

 security/libpki/Makefile                       |  5 ++---
 security/libpki/files/patch-configure.ac (new) | 13 +++++++++++++
 2 files changed, 15 insertions(+), 3 deletions(-)
Comment 6 Nuno Teixeira freebsd_committer freebsd_triage 2022-10-15 16:25:40 UTC
Committed, thanks!