lpe 1.2.5 as built from today's ports (nothing interesting in the commit logs anyway) will dump core without fail when a file when fopen() fails on an existing file (eg, permission denied) The homespun die() lpe.c incorrectly tries to free() each node in the doubly linked list of lines of text in its internal storage buffer, when (portions of) that buffer may not have been initialized as a result of a premature exit. Fix: Solution is to prevent die() from free()ing nodes if the text buffer is null. How-To-Repeat: chmod 000 somefile lpe somefile (as a normal user ;-)
Looks like this should be added to files/. Did you submit this patch to maintainer? (new email address: calle.madestrand@norrgarden.se) You may also wish to submit this patch to the lpe authors too, since it's a generic bugfix not specific to FreeBSD only. Thanks! -- jimmy
Jimmy Olgeni wrote to freebsd-gnats-submit@FreeBSD.org and ryan@sasknow.com: > Looks like this should be added to files/. Yes. > Did you submit this patch to maintainer? Yes. > (new email address: calle.madestrand@norrgarden.se) > > You may also wish to submit this patch to the lpe authors too, since > it's a generic bugfix not specific to FreeBSD only. Yes. > Thanks! > You're welcome! ;-) - Ryan -- Ryan Thompson <ryan@sasknow.com> Network Administrator, Accounts SaskNow Technologies - http://www.sasknow.com #106-380 3120 8th St E - Saskatoon, SK - S7H 0W2 Tel: 306-664-3600 Fax: 306-664-1161 Saskatoon Toll-Free: 877-727-5669 (877-SASKNOW) North America
State Changed From-To: open->closed Patch approved by maintainer in ports/26804, and committed. Thanks!