Created attachment 237231 [details] rdfind-1.5.0 Description: Rdfind is a command line tool that finds duplicate files. It is useful for compressing backup directories or just finding duplicate files. It compares files based on their content, NOT on their file names. WWW: https://github.com/pauldreik/rdfind QA: * portlint: OK (looks fine.) * testport: OK (poudriere: 13.1-RELEASE, amd64)
Please note <https://docs.freebsd.org/en/books/porters-handbook/book/#makefile-www> and other relevant parts of the Porter's Handbook. Thank you
Created attachment 237275 [details] rdfind-1.5.0 Description: * Change the COMMENT field. * Put the slash at the end of WWW. QA: * portlint: OK (looks fine.) * testport: OK (poudriere: 13.1-RELEASE, amd64)
(In reply to Graham Perrin from comment #1) Hi Graham, thank you for your recommendations!
(In reply to Jesús Daniel Colmenares Oviedo from comment #3) Thanks, I might be out of my depth here … <https://rdfind.pauldreik.se/> observes: > … the repository has been moved to Github. … – so, I am unsure about this part of your Makefile at comment #2: MASTER_SITES= https://rdfind.pauldreik.se/ Be aware of the USE_GITHUB framework, for example: <https://docs.freebsd.org/en/books/porters-handbook/book/#makefile-master_sites-github-ex1> …
Would you describe <https://rdfind.pauldreik.se/> as the home page, with the repository elsewhere (GitHub)? If so, then the better value for WWW might be https://rdfind.pauldreik.se/ Or, would you describe the GitHub repo as the new home page? I see releases/1.5.0 tagged in GitHub, plus the .tar.gz for 1.5.0 at <https://rdfind.pauldreik.se/>, however it's not clear to me whether each future tagged release in GitHub will be accompanied by another .tar.gz file in the pauldreik.se area …
Any reason why is HAS_CONFIGURE set instead of GNU_CONFIGURE? Looks fine to me otherwise
Created attachment 237293 [details] rdfind-1.5.0 Description: * Change WWW: homepage is https://rdfind.pauldreik.se * Add USES=autoreconf * Use USE_GITHUB framework instead of MASTER_SITES=https://rdfind.pauldreik.se * Update distinfo * Change share/man/man1/${PORTNAME}.1.gz to man/man1/${PORTNAME}.1.gz * Use GNU_CONFIGURE instead of HAS_CONFIGURE QA: * portlint: OK (looks fine.) * testport: OK (poudriere: 13.1-RELEASE, amd64)
Actually the previous revision is more correct to Porters Handbook, USE_GITHUB is only to be used when there no "no officially released file" which there is in this case. https://docs.freebsd.org/en/books/porters-handbook/book/#makefile-master_sites-github I'll fix the GNU_CONFIGURE line and probably commit it during the weekend if time permits.
(In reply to Graham Perrin from comment #4) > <https://rdfind.pauldreik.se/> observes: >> … the repository has been moved to Github. … Yes, I have seen it, but it looks like the author is still using his website to distribute rdfind. (In reply to Graham Perrin from comment #5) > Would you describe <https://rdfind.pauldreik.se/> as the home page, with the repository elsewhere (GitHub)? If so, then the better value for WWW might be https://rdfind.pauldreik.se/ I had put the Github website because it has the documentation, has the code and does the rest for the project, but I've changed it to the author's website because it points to the repository anyway. (In reply to Daniel Engberg from comment #6) > Any reason why is HAS_CONFIGURE set instead of GNU_CONFIGURE? Looks fine to me otherwise You are right, I have changed it. (In reply to Daniel Engberg from comment #8) Thank you Daniel!
Thanks people.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=9603c4b3eb4ea691c527804d10dd5b2e42391cdb commit 9603c4b3eb4ea691c527804d10dd5b2e42391cdb Author: Jesús Daniel Colmenares Oviedo <DtxdF@disroot.org> AuthorDate: 2022-10-16 20:42:50 +0000 Commit: Daniel Engberg <diizzy@FreeBSD.org> CommitDate: 2022-10-16 21:23:11 +0000 sysutils/rdfind: New port: Utility to find duplicate files based on content Command line utility that's useful for compressing backup directories or just finding duplicate files based on their content. Committers note: Patch modified to follow Porters Handbook more closely PR: 266985 sysutils/Makefile | 1 + sysutils/rdfind/Makefile (new) | 24 ++++++++++++++++++++++++ sysutils/rdfind/distinfo (new) | 3 +++ sysutils/rdfind/pkg-descr (new) | 3 +++ 4 files changed, 31 insertions(+)
Committed, thanks!