Created attachment 237327 [details] Patch for jdupes Unbundle xxHash [1] Unset -g during compilation Poudriere testport OK 12.3-RELEASE (amd64) Poudriere testport OK 13.1-RELEASE (i386) 1: https://github.com/jbruchon/jdupes/issues/217 ) an
Unsetting -g should be conditional on WITH_DEBUG, no? Is it actually worth doing that instead of relying on the ports system stripping conditionally?
We need to patch Makefile anyway so might as well remove it?
(In reply to Daniel Engberg from comment #2) Ah, see, CFLAGS gets merged in and will set -g for us, so just stripping it is correct. I think the -O2 should also be stripped so optimization level isn't set unconditionally. I'm also seeing an expr error on build from an attempt to detect gcc version. Looks like that can be stubbed out.
Created attachment 237569 [details] Patch for jdupes v2 Strip hardcoded optimization Remove hardcoded GCC version check
You're right, all of this should be fixed now
Comment on attachment 237569 [details] Patch for jdupes v2 Thanks Daniel, this looks good. - Passes poudriere-testport(8) on 13.1/amd64 - CFLAGS and WITH_DEBUG handled appropriately - No expr errors - jdupes(1) seems to work when comparing results on multiple trees with fdupes(1) I think the remaining linker warnings of ignoring attempts to set a new stack limit are harmless, since FreeBSD already has quite generous limits by default, even on 32-bit.
Comment on attachment 237569 [details] Patch for jdupes v2 Could have sworn I set maintainer-approval + there...
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=3375d85b5e7f7e4dec59696ed7f37debb0883fef commit 3375d85b5e7f7e4dec59696ed7f37debb0883fef Author: Daniel Engberg <diizzy@FreeBSD.org> AuthorDate: 2022-10-30 19:47:50 +0000 Commit: Daniel Engberg <diizzy@FreeBSD.org> CommitDate: 2022-10-30 20:04:23 +0000 sysutils/jdupes: Update to 1.21.0 Use xxHash from ports instead of bundled version Strip hardcoded optimization and -g Remove hardcoded GCC version check Changelog: https://github.com/jbruchon/jdupes/releases/tag/v1.21.0 PR: 267073 Reviewed by: Thomas Hurst <tom@hur.st> (maintainer) sysutils/jdupes/Makefile | 8 +++++-- sysutils/jdupes/distinfo | 6 +++--- sysutils/jdupes/files/patch-Makefile (new) | 34 ++++++++++++++++++++++++++++++ 3 files changed, 43 insertions(+), 5 deletions(-)
Committed, thanks