Created attachment 237390 [details] maintainer update for audio/hydrogen Update audio/hydrogen to v1.1.1 includes patch from https://github.com/hydrogen-music/hydrogen/issues/1665
^Triage: Bugfix release, merge to quarterly branch? ^Triage: Maintainer-feedback flag (+) not required unless requested (?) first. Thanks!
Committed, Thanks!
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=19c038c2294b65213bbe660dbc46c2306a610fcb commit 19c038c2294b65213bbe660dbc46c2306a610fcb Author: Shane <FreeBSD@ShaneWare.Biz> AuthorDate: 2022-10-17 05:51:41 +0000 Commit: Fernando Apesteguía <fernape@FreeBSD.org> CommitDate: 2022-10-17 15:55:53 +0000 audio/hydrogen: Update to v1.1.1 ChangeLog: https://github.com/hydrogen-music/hydrogen/blob/master/ChangeLog#L178 * Bugfixes - fix preferences dialog "OK" button behavior - fix rewinding to beginning of pattern in pattern mode with no pattern inserted in SongEditor - fix display of tempo marker while loading a song (introduced in 1.1.0) - fix LADSPA issues, most audible on PulseAudio - fix window placement when screen sizes change * Explicitly set latency target for PortAudio (Windows) audio driver, enabling much lower audio latency on Windows. PR: 267137 Reported by: FreeBSD@ShaneWare.Biz (maintainer) audio/hydrogen/Makefile | 7 +- audio/hydrogen/distinfo | 6 +- .../files/patch-data_i18n_CMakeLists.txt (gone) | 11 -- .../hydrogen/files/patch-src_core_Logger.cpp (new) | 10 ++ audio/hydrogen/pkg-plist | 146 +++++++++++---------- 5 files changed, 92 insertions(+), 88 deletions(-)
Any reason why we're not using upstream release archive as instructed by USE_GITLAB section is Porters Handbook? https://github.com/hydrogen-music/hydrogen/releases/download/1.1.1/hydrogen-1.1.1.tar.gz https://sourceforge.net/projects/hydrogen/files/Hydrogen/1.1.1%20Sources/hydrogen-1.1.1.tar.gz Are localbase paths needed for options? (localbase:ldflags fixes it perhaps?) Best regards, Daniel
(In reply to Daniel Engberg from comment #4) I assume you mean USE_GITHUB, since that is what the port uses? Yes, I think it would work. Could the maintainer have a look at it?, Or Daniel, please be my guest and have a crack at it if you want. Cheers.
(In reply to Daniel Engberg from comment #4) Not sure what you are referring to with the release archive. It uses DISTVERSION to get the tagged release tarball from github. Not sure that the LIBTAR path is still a requirement, the others are needed. I think this one is from before localbase was created. Using localbase:ldflags will add -L${LOCALBASE}/lib but lib/ladspa needs to be added for the LADSPA option. Similarly RDF needs the include/raptor2 subpath added. I do think they should be using PREFIX instead of LOCALBASE
(In reply to Shane from comment #6) USE_GITHUB pull down a generated "snapshot" of the repo, not the static tarballs which are to be used if available. See https://cgit.freebsd.org/ports/tree/Mk/bsd.sites.mk#n260 for more information. I would suggest that use use GitHub as primary and SF as fallback in MASTER_SITES. Regarding localbase, I just found it a bit odd since most distributions seems to not specify paths but I didn't look into it any further.