Bug 267186 - audio/hydrogen: Use upstream release archive
Summary: audio/hydrogen: Use upstream release archive
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Daniel Engberg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-10-18 20:41 UTC by Daniel Engberg
Modified: 2022-10-22 08:11 UTC (History)
1 user (show)

See Also:
FreeBSD: maintainer-feedback+

Attachments
Patch for hydrogen (5.69 KB, patch)
2022-10-18 20:41 UTC, Daniel Engberg 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Engberg freebsd_committer freebsd_triage 2022-10-18 20:41:14 UTC 
Created attachment 237444 [details]
Patch for hydrogen

Use upstream release archive as recommended by Porters Handbook (USE_GITHUB section)
Update compiler requirements to c++17-lang
Adjust manpage install dir

Compile tested on FreeBSD 13.1-STABLE (amd64) (make, make check-plist)
Comment 1 Shane 2022-10-19 10:30:57 UTC 
If you want to move the manpage into man/man1 then you don't need to set CMAKE_INSTALL_MANDIR, this was set because moving the manpage caused a packaging error.

Otherwise, I'm ok with the changes
Comment 2 Daniel Engberg freebsd_committer freebsd_triage 2022-10-22 07:45:20 UTC 
Removing causes it to end up in share so we need to keep it
Comment 3 commit-hook freebsd_committer freebsd_triage 2022-10-22 08:11:03 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=7a20f9d5b476ca2cb41f79f34f5de6fe86f15995

commit 7a20f9d5b476ca2cb41f79f34f5de6fe86f15995
Author:     Daniel Engberg <diizzy@FreeBSD.org>
AuthorDate: 2022-10-22 07:46:16 +0000
Commit:     Daniel Engberg <diizzy@FreeBSD.org>
CommitDate: 2022-10-22 07:46:20 +0000

    audio/hydrogen: Use upstream release archive

    - Use upstream release archive as recommended by Porters Handbook
      (USE_GITHUB section)
    - Update compiler requirements to c++17-lang
    - Adjust manpage install dir

    PR:             267186
    Reviewed by:    Shane <FreeBSD@ShaneWare.Biz> (maintainer)

 audio/hydrogen/Makefile  |  8 +++---
 audio/hydrogen/distinfo  |  6 ++---
 audio/hydrogen/pkg-plist | 69 +++++++++++++++++++++++++++++++++++++++++++++++-
 3 files changed, 75 insertions(+), 8 deletions(-)