Bug 267197 - security/yubikey-agent: Fix build on 32-bit platforms
Summary: security/yubikey-agent: Fix build on 32-bit platforms
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Nuno Teixeira
URL: https://github.com/go-piv/piv-go/comm...
Keywords:
Depends on:
Blocks:
 
Reported: 2022-10-19 12:41 UTC by Robert Clausecker
Modified: 2022-11-03 23:53 UTC (History)
2 users (show)

See Also:
fuz: maintainer-feedback-
eduardo: merge-quarterly+

Attachments
security/yubikey-agent: fix build on 32 bit platforms (1.34 KB, patch)
2022-10-19 12:41 UTC, Robert Clausecker 		fuz: maintainer-approval+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Clausecker freebsd_committer freebsd_triage 2022-10-19 12:41:26 UTC 
Created attachment 237456 [details]
security/yubikey-agent: fix build on 32 bit platforms

This imports an upstream patch from dependency
github.com/go-piv/piv-go to address a missing cast.

See also: https://github.com/go-piv/piv-go/commit/1902689552e974ba88750e3ab71902d253172ead

Tested with Poudriere on i386 amd64 armv7 arm64 FreeBSD 13.1.
Please MFH if possible.
Comment 1 Robert Clausecker freebsd_committer freebsd_triage 2022-11-03 14:52:19 UTC 
Maintainer timeout
Comment 2 Robert Clausecker freebsd_committer freebsd_triage 2022-11-03 14:52:32 UTC 
Comment on attachment 237456 [details]
security/yubikey-agent: fix build on 32 bit platforms

Maintainer timeout on patch
Comment 3 Kubilay Kocak freebsd_committer freebsd_triage 2022-11-03 21:39:06 UTC 
^Triage: Maintainer timeout, open to take
Comment 4 commit-hook freebsd_committer freebsd_triage 2022-11-03 23:50:54 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=302d7c2ddde491d2ab6bc7e25dad42d46509007f

commit 302d7c2ddde491d2ab6bc7e25dad42d46509007f
Author:     Robert Clausecker <fuz@fuz.su>
AuthorDate: 2022-11-03 23:43:32 +0000
Commit:     Nuno Teixeira <eduardo@FreeBSD.org>
CommitDate: 2022-11-03 23:46:35 +0000

    security/yubikey-agent: Fix build on 32-bit platforms

    This imports an upstream patch from dependency
    github.com/go-piv/piv-go to address a missing cast.

    See also: https://github.com/go-piv/piv-go/commit/1902689552e974ba88750e3ab71902d253172ead

    PR:             267197
    Approved by:    maintainer timeout, >2 weeks
    MFH:            2022Q4

 security/yubikey-agent/Makefile                              |  4 +---
 ...endor_github.com_go-piv_piv-go_piv_pcsc__freebsd.go (new) | 12 ++++++++++++
 2 files changed, 13 insertions(+), 3 deletions(-)
Comment 5 commit-hook freebsd_committer freebsd_triage 2022-11-03 23:50:54 UTC 
A commit in branch 2022Q4 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=b048c3b1cd23c631fb0e48718231755361a08062

commit b048c3b1cd23c631fb0e48718231755361a08062
Author:     Robert Clausecker <fuz@fuz.su>
AuthorDate: 2022-11-03 23:43:32 +0000
Commit:     Nuno Teixeira <eduardo@FreeBSD.org>
CommitDate: 2022-11-03 23:48:04 +0000

    security/yubikey-agent: Fix build on 32-bit platforms

    This imports an upstream patch from dependency
    github.com/go-piv/piv-go to address a missing cast.

    See also: https://github.com/go-piv/piv-go/commit/1902689552e974ba88750e3ab71902d253172ead

    PR:             267197
    Approved by:    maintainer timeout, >2 weeks
    MFH:            2022Q4

    (cherry picked from commit 302d7c2ddde491d2ab6bc7e25dad42d46509007f)

 security/yubikey-agent/Makefile                              |  4 +---
 ...endor_github.com_go-piv_piv-go_piv_pcsc__freebsd.go (new) | 12 ++++++++++++
 2 files changed, 13 insertions(+), 3 deletions(-)
Comment 6 Nuno Teixeira freebsd_committer freebsd_triage 2022-11-03 23:53:36 UTC 
Committed, thank you!