Created attachment 237517 [details] Upgrade to 2.9.4 Summary of changes: https://github.com/storaged-project/udisks/releases/tag/udisks-2.9.3 and https://github.com/storaged-project/udisks/releases/tag/udisks-2.9.4 Full changes since 2.9.2: https://github.com/storaged-project/udisks/blob/c430dd9a27e158693cc783e9ee91bf6e5b2a8819/NEWS and https://github.com/storaged-project/udisks/blob/001c486e6d099ed33e2de4f5c73c03e3ee180f81/NEWS Reported by: portscout. While there: - consult portclippy - switch MAINTAINER to my @f.o address - use %%PORTVERSION%% in pkg-plist to avoid changing it on each upstream upgrade.
Maintainer informed via mail
^Triage: If this is a bugfix or security release, or quarterly users are affected, please set merge-quarterly flag to: ?
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=4b8953300ff9a327ad32a6d80fc3b8abcb6f603b commit 4b8953300ff9a327ad32a6d80fc3b8abcb6f603b Author: Pau Amma <pauamma@FreeBSD.org> AuthorDate: 2022-10-22 02:34:32 +0000 Commit: Nuno Teixeira <eduardo@FreeBSD.org> CommitDate: 2022-10-22 02:34:32 +0000 sysutils/libudisks: Update to 2.9.4 - consult portclippy - switch MAINTAINER to my @f.o address - use %%PORTVERSION%% in pkg-plist to avoid changing it on each upstream upgrade ChangeLog: https://github.com/storaged-project/udisks/blob/udisks-2.9.4/NEWS PR: 267263 MFH: 2022Q4 (bugfixes) sysutils/libudisks/Makefile | 10 ++++++---- sysutils/libudisks/distinfo | 6 +++--- sysutils/libudisks/pkg-plist | 2 +- 3 files changed, 10 insertions(+), 8 deletions(-)
A commit in branch 2022Q4 references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=387b0285cc2767ac693366f6dc4f99811fc1675c commit 387b0285cc2767ac693366f6dc4f99811fc1675c Author: Pau Amma <pauamma@FreeBSD.org> AuthorDate: 2022-10-22 02:34:32 +0000 Commit: Nuno Teixeira <eduardo@FreeBSD.org> CommitDate: 2022-10-22 02:38:35 +0000 sysutils/libudisks: Update to 2.9.4 - consult portclippy - switch MAINTAINER to my @f.o address - use %%PORTVERSION%% in pkg-plist to avoid changing it on each upstream upgrade ChangeLog: https://github.com/storaged-project/udisks/blob/udisks-2.9.4/NEWS PR: 267263 MFH: 2022Q4 (bugfixes) (cherry picked from commit 4b8953300ff9a327ad32a6d80fc3b8abcb6f603b) sysutils/libudisks/Makefile | 10 ++++++---- sysutils/libudisks/distinfo | 6 +++--- sysutils/libudisks/pkg-plist | 2 +- 3 files changed, 10 insertions(+), 8 deletions(-)
Committed, thanks!
Any reason why we're not using the official release archive? https://github.com/storaged-project/udisks/releases/tag/udisks-2.9.4 Nitpick but Porters Handbook also suggests to use DISTVERSION
(In reply to Daniel Engberg from comment #6) If you mean to get the source tarball: I use whatever > USE_GITHUB= yes > GH_ACCOUNT= storaged-project > GH_PROJECT= udisks gives me. I figure if there's ports framework support for it, then it must be an acceptable way to download source code, if not the best one in all cases. Re your nitpick: DISTVERSION instead of... PORTVERSION and DISTVERSIONPREFIX? I seem to remember the way I use is what someone suggested when I first created the port. Comment just above explains their reason for it. (Keep in mind: first port, and so far only one.)
Created attachment 237523 [details] sugestion v0 - switch to DISTVERSION - switch to MASTER_SITES (static tarball) Fails to configure: --- ===> Configuring for libudisks-2.9.4 cd /wrkdirs/usr/ports/sysutils/libudisks/work/udisks-2.9.4 && /usr/bin/env NOCONFIGURE=1 ./autogen.sh env: ./autogen.sh: No such file or directory --- Any clues? Can't figure out where NOCONFIGURE=1 cames from. Cheers
Nuno, I forgot to link. :( I've submitted a few improvements here: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=267268
(In reply to Daniel Engberg from comment #9) Nice! Looks good. Thanks