Bug 267285 - math/sundials: Use USE_GITHUB
Summary: math/sundials: Use USE_GITHUB
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Yuri Victorovich
URL: https://github.com/LLNL/sundials/issu...
Keywords:
Depends on:
Blocks:
 
Reported: 2022-10-23 08:21 UTC by Daniel Engberg
Modified: 2022-10-24 18:15 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (yuri)

Attachments
Patch for sundails (1.22 KB, patch)
2022-10-23 08:21 UTC, Daniel Engberg 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Engberg freebsd_committer freebsd_triage 2022-10-23 08:21:07 UTC 
Created attachment 237548 [details]
Patch for sundails

Compile tested on FreeBSD 13.1-STABLE
Comment 1 Yuri Victorovich freebsd_committer freebsd_triage 2022-10-23 17:58:45 UTC 
Adding a related URL.
Comment 2 Yuri Victorovich freebsd_committer freebsd_triage 2022-10-23 18:00:24 UTC 
I am not sure that this change is good.

Both ways (before and after) seem to generate tarballs on the fly. So why is the "after" way better than the "before" way?
Comment 3 commit-hook freebsd_committer freebsd_triage 2022-10-24 18:15:05 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=ccbf2582168a837e25d133746d59e5037be5ef52

commit ccbf2582168a837e25d133746d59e5037be5ef52
Author:     Yuri Victorovich <yuri@FreeBSD.org>
AuthorDate: 2022-10-24 14:24:03 +0000
Commit:     Yuri Victorovich <yuri@FreeBSD.org>
CommitDate: 2022-10-24 18:14:53 +0000

    math/sundials: Use tarball (again) provided by the upstream; Correct WWW

    Also improve CMAKExx and other lines.

    PR:             267285
    Reported by:    diizzy@ (tarball-related)

 math/sundials/Makefile | 14 +++++++-------
 math/sundials/distinfo |  6 +++---
 2 files changed, 10 insertions(+), 10 deletions(-)
Comment 4 Yuri Victorovich freebsd_committer freebsd_triage 2022-10-24 18:15:19 UTC 
Using supplied tarball again now.

Thanks for reporting!