Bug 267286 - cad/xyce: Use USE_GITHUB
Summary: cad/xyce: Use USE_GITHUB
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Yuri Victorovich
URL: https://github.com/Xyce/Xyce/issues/80
Keywords:
Depends on:
Blocks:
 
Reported: 2022-10-23 08:21 UTC by Daniel Engberg
Modified: 2022-10-30 16:59 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (yuri)

Attachments
Patch for xyce (1.50 KB, patch)
2022-10-23 08:21 UTC, Daniel Engberg 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Engberg freebsd_committer freebsd_triage 2022-10-23 08:21:59 UTC 
Created attachment 237549 [details]
Patch for xyce

Compile tested on FreeBSD 13.1-STABLE
Comment 1 Yuri Victorovich freebsd_committer freebsd_triage 2022-10-23 17:54:21 UTC 
Daniel,

Why this change?

Doesn't the porter's handbook call to use tarballs when they are provided?


Yuri
Comment 2 Daniel Engberg freebsd_committer freebsd_triage 2022-10-23 19:18:07 UTC 
I guess the handbook isn't as detailed as it could be regarding this topic. It does indeed promote using a tarball as long as it's static. This isn't clear as all uses of GitHub involves on the fly unless upstream attaches a static tarball to a release. A 3D cube icon and a proper file name listed in ~99% of all cases is a static one while the "zip-file" like icons and "Source code" titled ones are generated on the fly.

Example: https://github.com/hydrogen-music/hydrogen/releases/tag/1.1.1

I'm suggesting this change to make the tree consistent, USE_GITHUB will use generated on the fly tarballs however all ports will use the same method which also makes maintenance easier.

A quick comparison (not 100% accurate but close enough)

grep -ir MASTER_SITES --include Makefile /usr/ports/ | grep github | grep /archive/ | wc -l
      16

grep -ir USE_GITHUB --include Makefile /usr/ports/ | wc -l
    5476

Best regards,
Daniel
Comment 3 Yuri Victorovich freebsd_committer freebsd_triage 2022-10-23 19:48:18 UTC 
(In reply to Daniel Engberg from comment #2)

Auto-generated tarballs usually have the same name as tag. In the Xyce case the tarball is not auto-generated.

So I don't see why this should be changed in this port.
Comment 4 Yuri Victorovich freebsd_committer freebsd_triage 2022-10-23 19:51:31 UTC 
Adding relevant URL.
Comment 5 Daniel Engberg freebsd_committer freebsd_triage 2022-10-23 20:10:17 UTC 
Not according to 
https://github.com/orgs/community/discussions/32478
https://github.com/bazelbuild/bazel/issues/15128 --> https://github.com/bazel-contrib/SIG-rules-authors/issues/11 .

I'd take the claim of "guaranteed to be stable" very cautiously
Comment 6 Yuri Victorovich freebsd_committer freebsd_triage 2022-10-30 16:58:48 UTC 
Committed, thanks!
Comment 7 commit-hook freebsd_committer freebsd_triage 2022-10-30 16:59:50 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=bd3990624fc391e902bd19252927cfbfabf8776f

commit bd3990624fc391e902bd19252927cfbfabf8776f
Author:     Daniel Engberg <diizzy@FreeBSD.org>
AuthorDate: 2022-10-30 16:57:37 +0000
Commit:     Yuri Victorovich <yuri@FreeBSD.org>
CommitDate: 2022-10-30 16:57:37 +0000

    cad/xyce: Use USE_GITHUB

    PR:             267286

 cad/xyce/Makefile | 8 ++++----
 cad/xyce/distinfo | 6 +++---
 2 files changed, 7 insertions(+), 7 deletions(-)