Bug 267352 - security/strongswan: Add GCM option to OPTIONS_DEFAULT
Summary: security/strongswan: Add GCM option to OPTIONS_DEFAULT
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Nuno Teixeira
URL: https://github.com/strongswan/strongs...
Keywords: patch
Depends on:
Blocks:
 
Reported: 2022-10-26 07:39 UTC by Jose Luis Duran
Modified: 2022-10-26 14:46 UTC (History)
2 users (show)

See Also:
strongswan: maintainer-feedback+
eduardo: merge-quarterly+


Attachments
Add GCM option to OPTIONS_DEFAULT (704 bytes, patch)
2022-10-26 07:39 UTC, Jose Luis Duran
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jose Luis Duran 2022-10-26 07:39:36 UTC
Created attachment 237640 [details]
Add GCM option to OPTIONS_DEFAULT

Avoid the message:

plugin 'gcm': failed to load - gcm_plugin_create not found and no plugin file available

According to strongSwan's 5.9.8 release notes[1]:

- The gcm plugin has been enabled by default, so that the TLS 1.3 unit tests (now indirectly enabled if the pki tool is built due to the implementation of EST) can be completed successfully with just the default plugins.
    
Let's also enable it by default.
    
[1]: https://github.com/strongswan/strongswan/releases/tag/5.9.8
Comment 1 Francois ten Krooden 2022-10-26 09:53:10 UTC
Happy with the update
Comment 2 commit-hook freebsd_committer freebsd_triage 2022-10-26 14:39:39 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=a0103c803b137d9cd95310bbfd315103d8e046b2

commit a0103c803b137d9cd95310bbfd315103d8e046b2
Author:     Jose Luis Duran <jlduran@gmail.com>
AuthorDate: 2022-10-26 14:35:42 +0000
Commit:     Nuno Teixeira <eduardo@FreeBSD.org>
CommitDate: 2022-10-26 14:35:42 +0000

    security/strongswan: Add GCM option to OPTIONS_DEFAULT

     Avoid the message:

     "plugin 'gcm': failed to load - gcm_plugin_create not found and no
     plugin file available"

     According to strongSwan's 5.9.8 release notes[1]:

     The gcm plugin has been enabled by default, so that the TLS 1.3 unit
     tests (now indirectly enabled if the pki tool is built due to the
     implementation of EST) can be completed successfully with just the
     default plugins.

     Let's also enable it by default.

     [1]: https://github.com/strongswan/strongswan/releases/tag/5.9.8

    PR:             267352

 security/strongswan/Makefile    | 3 ++-
 security/strongswan/pkg-message | 1 -
 2 files changed, 2 insertions(+), 2 deletions(-)
Comment 3 Nuno Teixeira freebsd_committer freebsd_triage 2022-10-26 14:40:19 UTC
Committed, thanks!
Comment 4 commit-hook freebsd_committer freebsd_triage 2022-10-26 14:45:40 UTC
A commit in branch 2022Q4 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=4e980e50e099bace64b0939a5403002ec4f2a337

commit 4e980e50e099bace64b0939a5403002ec4f2a337
Author:     Jose Luis Duran <jlduran@gmail.com>
AuthorDate: 2022-10-26 14:35:42 +0000
Commit:     Nuno Teixeira <eduardo@FreeBSD.org>
CommitDate: 2022-10-26 14:42:56 +0000

    security/strongswan: Add GCM option to OPTIONS_DEFAULT

     Avoid the message:

     "plugin 'gcm': failed to load - gcm_plugin_create not found and no
     plugin file available"

     According to strongSwan's 5.9.8 release notes[1]:

     The gcm plugin has been enabled by default, so that the TLS 1.3 unit
     tests (now indirectly enabled if the pki tool is built due to the
     implementation of EST) can be completed successfully with just the
     default plugins.

     Let's also enable it by default.

     [1]: https://github.com/strongswan/strongswan/releases/tag/5.9.8

    PR:             267352
    (cherry picked from commit a0103c803b137d9cd95310bbfd315103d8e046b2)

 security/strongswan/Makefile    | 3 ++-
 security/strongswan/pkg-message | 1 -
 2 files changed, 2 insertions(+), 2 deletions(-)
Comment 5 Nuno Teixeira freebsd_committer freebsd_triage 2022-10-26 14:46:46 UTC
Committed, thanks!