Bug 267382 - www/newsboat: Upgrade to 2.29
Summary: www/newsboat: Upgrade to 2.29
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Nuno Teixeira
URL: https://github.com/newsboat/newsboat/...
Keywords: needs-patch, needs-qa
Depends on:
Blocks:
 
Reported: 2022-10-27 06:40 UTC by Marko Turk
Modified: 2022-10-28 17:07 UTC (History)
2 users (show)

See Also:
mt-bugs: maintainer-feedback+

Attachments
patch (28.09 KB, patch)
2022-10-27 06:40 UTC, Marko Turk 		mt-bugs: maintainer-approval-
Details | Diff
Makefile.crates use (29.40 KB, patch)
2022-10-27 10:44 UTC, Nuno Teixeira 		mt-bugs: maintainer-approval-
Details | Diff
patch (29.94 KB, patch)
2022-10-28 16:08 UTC, Marko Turk 		mt-bugs: maintainer-approval+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Marko Turk 2022-10-27 06:40:35 UTC 
Created attachment 237672 [details]
patch

Hi,

patch to upgrade newsboat port to 2.29.

Changelog:
https://github.com/newsboat/newsboat/blob/master/CHANGELOG.md#229---2022-09-25

Regards
Comment 1 Nuno Teixeira freebsd_committer freebsd_triage 2022-10-27 10:44:50 UTC 
Created attachment 237675 [details]
Makefile.crates use

Sugestion:

Use Makefile.crates for CARGO-CRATES list instead of including it in Makefile.
Result is a cleaner Makefile and easier future updates.

---
Mk/Uses/cargo.mk:
.sinclude "${MASTERDIR}/Makefile.crates"
---
Comment 2 Nuno Teixeira freebsd_committer freebsd_triage 2022-10-27 11:04:33 UTC 
====> Running Q/A tests (stage-qa)
====> Checking for pkg-plist issues (check-plist)
===> Parsing plist
===> Checking for items in STAGEDIR missing from pkg-plist
Error: Orphaned: %%PORTDOCS%%%%DOCSDIR%%/contrib/newsboat_reorganize.py
===> Checking for items in pkg-plist which are not in STAGEDIR
===> Error: Plist issues found.
Comment 3 Marko Turk 2022-10-28 16:08:14 UTC 
Hi,

attaching new patch with both Makefiles.crates and with plist fix.

Thanks for the help.

Regards.
Comment 4 Marko Turk 2022-10-28 16:08:36 UTC 
Created attachment 237692 [details]
patch
Comment 5 commit-hook freebsd_committer freebsd_triage 2022-10-28 17:07:14 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=2eda7fb28684c4afeb732c7e7941ae5cf8bc8fd2

commit 2eda7fb28684c4afeb732c7e7941ae5cf8bc8fd2
Author:     Marko Turk <mt-bugs@markoturk.info>
AuthorDate: 2022-10-28 17:03:25 +0000
Commit:     Nuno Teixeira <eduardo@FreeBSD.org>
CommitDate: 2022-10-28 17:04:36 +0000

    www/newsboat: Update to 2.29

    ChangeLog: https://github.com/newsboat/newsboat/blob/r2.29/CHANGELOG.md

    PR:             267382

 www/newsboat/Makefile              |  99 +----------------
 www/newsboat/Makefile.crates (new) | 105 ++++++++++++++++++
 www/newsboat/distinfo              | 218 ++++++++++++++++++++-----------------
 www/newsboat/pkg-plist             |   1 +
 4 files changed, 230 insertions(+), 193 deletions(-)
Comment 6 Nuno Teixeira freebsd_committer freebsd_triage 2022-10-28 17:07:39 UTC 
Committed, thanks!