Bug 267395 - graphics/libemf: fix build on riscv64
Summary: graphics/libemf: fix build on riscv64
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: riscv Any
: --- Affects Some People
Assignee: Juraj Lutter
URL: https://github.com/freebsd/freebsd-po...
Keywords:
Depends on:
Blocks:
 
Reported: 2022-10-27 17:03 UTC by Robert Clausecker
Modified: 2022-11-13 13:48 UTC (History)
4 users (show)

See Also:
fuz: maintainer-feedback-
grahamperrin: merge-quarterly?

Attachments
graphics/libemf: fix build on riscv64 (3.26 KB, patch)
2022-10-27 17:03 UTC, Robert Clausecker 		fuz: maintainer-approval+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Clausecker freebsd_committer freebsd_triage 2022-10-27 17:03:42 UTC 
Created attachment 237684 [details]
graphics/libemf: fix build on riscv64

Add missing RISC-V specific bits to winnt.h to make the build succeed.
These bits are custom written stubs.

Test with Poudriere on riscv64 armv7 arm64 FreeBSD 13.1.
"make test" passes.
Comment 1 Robert Clausecker freebsd_committer freebsd_triage 2022-11-11 10:23:18 UTC 
Comment on attachment 237684 [details]
graphics/libemf: fix build on riscv64

maintainer timeout on patch
Comment 2 Robert Clausecker freebsd_committer freebsd_triage 2022-11-11 10:23:28 UTC 
maintainer timeout
Comment 3 commit-hook freebsd_committer freebsd_triage 2022-11-11 20:50:29 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=2ff55486c6332a41e6ce8ebd9fcee56d467a012e

commit 2ff55486c6332a41e6ce8ebd9fcee56d467a012e
Author:     Robert Clausecker <fuz@fuz.su>
AuthorDate: 2022-11-11 20:49:16 +0000
Commit:     Juraj Lutter <otis@FreeBSD.org>
CommitDate: 2022-11-11 20:49:16 +0000

    graphics/libemf: fix build on riscv64

    Add missing RISC-V specific bits to winnt.h to make the build succeed.
    These bits are custom written stubs.

    PR:             267395
    Approved by:    maintainer timeout

 graphics/libemf/Makefile                           |  2 -
 .../files/patch-include_libEMF_wine_winnt.h (new)  | 85 ++++++++++++++++++++++
 2 files changed, 85 insertions(+), 2 deletions(-)
Comment 4 Juraj Lutter freebsd_committer freebsd_triage 2022-11-11 20:52:17 UTC 
Committed, thanks.
Comment 5 Graham Perrin freebsd_committer freebsd_triage 2022-11-13 00:45:09 UTC 
Merge from main to 2022Q4?

Thanks
Comment 6 commit-hook freebsd_committer freebsd_triage 2022-11-13 12:39:54 UTC 
A commit in branch 2022Q4 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=96ca1951b9af07aea6c84f36eb36284b16282a0b

commit 96ca1951b9af07aea6c84f36eb36284b16282a0b
Author:     Robert Clausecker <fuz@fuz.su>
AuthorDate: 2022-11-11 20:49:16 +0000
Commit:     Juraj Lutter <otis@FreeBSD.org>
CommitDate: 2022-11-13 12:39:13 +0000

    graphics/libemf: fix build on riscv64

    Add missing RISC-V specific bits to winnt.h to make the build succeed.
    These bits are custom written stubs.

    PR:             267395
    Approved by:    maintainer timeout

    (cherry picked from commit 2ff55486c6332a41e6ce8ebd9fcee56d467a012e)

 graphics/libemf/Makefile                           |  2 -
 .../files/patch-include_libEMF_wine_winnt.h (new)  | 85 ++++++++++++++++++++++
 2 files changed, 85 insertions(+), 2 deletions(-)
Comment 7 Juraj Lutter freebsd_committer freebsd_triage 2022-11-13 13:48:06 UTC 
MFH'd.