Created attachment 237705 [details] [patch] security/sssd: explicitly disable po4a to fix plist problems in case it's installed If textproc/po4a is installed, configure detects this: checking for po4a... po4a When po4a is enabled, the build tries to regenerate man pages. In doing so, it fails to rebuild man pages for some locales. This may be because of a problem with something in sssd-1.16.5's build configuration, or it may be dependent on locale settings (when I built, LANG=en_US.UTF-8 was set). This incomplete man page generation causes plist errors - because of the missing man pages for some locales [[1]]. But there's no need to regenerate man pages as they are already included in the 1.16.5 distribution tarball. There's also no need to dig into exactly why some man pages are not built [[2]]. So disabling po4a seems like the simplest & best fix - not to mention that the man page generation adds quite a bit of time to the build. The attached patch explicitly disables po4a for a more consistent (and faster) build whether po4a is installed or not. There's no need to bump PORTREVISION since this will only fix a plist error and only for those users who have po4a installed. Since po4a is not a build dependency, builds in a "clean" environment (like poudriere) will not have this problem. [[1]] ===> Registering installation for sssd-1.16.5_7 pkg-static: Unable to access file /usr/ports/security/sssd/work-default/stage/usr/local/man/de/man5/sssd-ldap.5.gz:No such file or directory pkg-static: Unable to access file /usr/ports/security/sssd/work-default/stage/usr/local/man/es/man8/sssd.8.gz:No such file or directory pkg-static: Unable to access file /usr/ports/security/sssd/work-default/stage/usr/local/man/fr/man8/sssd.8.gz:No such file or directory pkg-static: Unable to access file /usr/ports/security/sssd/work-default/stage/usr/local/man/ja/man8/sssd.8.gz:No such file or directory *** Error code 1 [[2]] This version of sssd, 1.16.5, is quite old, and not worth investigating something like man page generation, IMO. See also bug 264526, comment 8 (and comments 12-14 there as well).
QA: portlint (ok, no new warnings/errors) portclippy (no new poudriere (testport ok - 12/stable-amd64, SMB option on) Note: there is an unrelated plist problem with SMB off. That existed before and after this patch: ===> Checking for items in pkg-plist which are not in STAGEDIR Error: Missing: %%PYTHON_SITELIBDIR%%/SSSDConfig-1.16.5-py%%PYTHON_VER%%.egg-info
(In reply to John Hein from comment #1) Didn't found issues with plist with SMB on/off (off by default) on poudriere. Did found that with SMB it build samba413 and samba412 while depends only mention samba412.
Comment on attachment 237705 [details] [patch] security/sssd: explicitly disable po4a to fix plist problems in case it's installed This is still a failure (security/sssd currently at 1.16.5_10) - as described in comment 0. Install textproc/po4a first, then 'make stage check-plist' to reproduce. Maintainer timeout long ago. To repeat what was already mentioned, there is no need to bump PORTREVISION. This will not change a port that successfully built (e.g., if po4a was not installed).
(In reply to John Hein from comment #3) I hope to get to this later today. John: Have you tried sssd-devel? I ask because my $WORK is the only user I know of.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=b2fdcc987fc01a804a1094b7c09b581393fa4b7c commit b2fdcc987fc01a804a1094b7c09b581393fa4b7c Author: Dan Langille <dvl@FreeBSD.org> AuthorDate: 2023-11-05 14:18:20 +0000 Commit: Dan Langille <dvl@FreeBSD.org> CommitDate: 2023-11-05 14:18:20 +0000 security/sssd: disable po4a Disable po4a. It is not an explicit build dependency, nor should it be. There is no need to use it to rebuild man pages with the current (1.16.5) distribution tarball. And using po4a (currently 0.68) somehow fails to create man pages for some locales. PR: 267415 Approved by: portmgr (maintainer timeout, 4+ months) security/sssd/Makefile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
A commit in branch 2023Q4 references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=b63d6fac3ccf766b779da7222840aedd882cb07a commit b63d6fac3ccf766b779da7222840aedd882cb07a Author: Dan Langille <dvl@FreeBSD.org> AuthorDate: 2023-11-05 14:18:20 +0000 Commit: Dan Langille <dvl@FreeBSD.org> CommitDate: 2023-11-05 14:23:09 +0000 security/sssd: disable po4a Disable po4a. It is not an explicit build dependency, nor should it be. There is no need to use it to rebuild man pages with the current (1.16.5) distribution tarball. And using po4a (currently 0.68) somehow fails to create man pages for some locales. PR: 267415 Approved by: portmgr (maintainer timeout, 4+ months) (cherry picked from commit b2fdcc987fc01a804a1094b7c09b581393fa4b7c) security/sssd/Makefile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
Committed and merged to quarterly branch. Thank you.