Bug 267422 - databases/mysql80-server: fix build on armv7
Summary: databases/mysql80-server: fix build on armv7
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: arm Any
: --- Affects Only Me
Assignee: Jochen Neumeister
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-10-29 15:15 UTC by Robert Clausecker
Modified: 2022-12-07 18:52 UTC (History)
2 users (show)

See Also:
fuz: maintainer-feedback? (joneum)
fuz: merge-quarterly?


Attachments
databases/mysql80-server: fix build on armv7 (1.26 KB, patch)
2022-10-29 15:15 UTC, Robert Clausecker
fuz: maintainer-approval+
Details | Diff
Attachment #237711 test build log on armv7 FreeBSD 13.1. (133.16 KB, application/x-xz)
2022-11-19 10:58 UTC, Robert Clausecker
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Clausecker freebsd_committer freebsd_triage 2022-10-29 15:15:44 UTC
Created attachment 237711 [details]
databases/mysql80-server: fix build on armv7

The fields of struct timespec have types (time_t, long), not (time_t, time_t).  Change one of our patches to reflect this, fixing the build on ARMv7.

Tested with Poudriere on amd64 armv7 FreeBSD 13.1.
Please MFH if possible.
Comment 1 Robert Clausecker freebsd_committer freebsd_triage 2022-11-08 07:26:00 UTC
@grahamperrin Any progress with this one?
Comment 2 Robert Clausecker freebsd_committer freebsd_triage 2022-11-18 20:53:02 UTC
Comment on attachment 237711 [details]
databases/mysql80-server: fix build on armv7

Maintainer timeout on patch
Comment 3 Robert Clausecker freebsd_committer freebsd_triage 2022-11-18 20:53:12 UTC
maintainer timeout
Comment 4 Jochen Neumeister freebsd_committer freebsd_triage 2022-11-18 21:31:07 UTC
i need a log please that it's ok. i can't approve it like this
Comment 5 Robert Clausecker freebsd_committer freebsd_triage 2022-11-19 00:24:28 UTC
(In reply to Jochen Neumeister from comment #4)

Why haven't you said so three weeks ago when I filed the PR?  Now we've lost a lot of time.  I'll go ahead and produce a fresh build log.  Should be done in a few hours.
Comment 6 Robert Clausecker freebsd_committer freebsd_triage 2022-11-19 10:58:23 UTC
Created attachment 238175 [details]
Attachment #237711 [details] test build log on armv7 FreeBSD 13.1.

Please see attached build log on armv7 FreeBSD 13.1.
Can produce further build logs if desired.
Comment 7 Jochen Neumeister freebsd_committer freebsd_triage 2022-11-22 10:27:38 UTC
The patch makes problems on CURRENT amd64. I will have a closer look
Comment 8 commit-hook freebsd_committer freebsd_triage 2022-12-02 13:15:14 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=315977f1bd5da135727487a9d615963bfb7f94e7

commit 315977f1bd5da135727487a9d615963bfb7f94e7
Author:     Jochen Neumeister <joneum@FreeBSD.org>
AuthorDate: 2022-12-02 13:12:29 +0000
Commit:     Jochen Neumeister <joneum@FreeBSD.org>
CommitDate: 2022-12-02 13:14:14 +0000

    databases/mysql80-server: fix build on armv7

    PR:     267422
    Sponsored by:   Netzkommune GmbH

 ...er_src_harness_include_mysql_harness_net_ts_impl_kqueue_io_service.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 9 Florian Smeets freebsd_committer freebsd_triage 2022-12-02 19:13:13 UTC
(In reply to commit-hook from comment #8)
@joneum This commit has the wrong Author: or is missing a Submitted by:

What about the request to merge to quarterly? Robert, do you still need this in quarterly? Jörn, will you take care of it, otherwise I will.
Comment 10 Robert Clausecker freebsd_committer freebsd_triage 2022-12-02 20:17:11 UTC
(In reply to Florian Smeets from comment #9)

I noticed the missing attribution, but it's unfortunately so common for committers to not care about these things that I stopped complaining. :-(

MFH would be much appreciated as mysql80-server is important software.
Comment 11 commit-hook freebsd_committer freebsd_triage 2022-12-07 18:52:32 UTC
A commit in branch 2022Q4 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=fbef78e7a9a85b3026c30e1d47a2ca85106ba34c

commit fbef78e7a9a85b3026c30e1d47a2ca85106ba34c
Author:     Jochen Neumeister <joneum@FreeBSD.org>
AuthorDate: 2022-12-02 13:12:29 +0000
Commit:     Florian Smeets <flo@FreeBSD.org>
CommitDate: 2022-12-07 18:45:39 +0000

    databases/mysql80-server: fix build on armv7

    PR:     267422
    Sponsored by:   Netzkommune GmbH
    Submitted by:   Robert Clausecker <fuz@fuz.su>

    (cherry picked from commit 315977f1bd5da135727487a9d615963bfb7f94e7)

 ...er_src_harness_include_mysql_harness_net_ts_impl_kqueue_io_service.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)