Bug 267424 - sysutils/loki: Switch log level default from "info" to "warn"
Summary: sysutils/loki: Switch log level default from "info" to "warn"
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Nuno Teixeira
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-10-29 16:49 UTC by Yonas Yanfa
Modified: 2022-11-10 15:54 UTC (History)
2 users (show)

See Also:
freebsd: maintainer-feedback+


Attachments
Diff to /usr/local/etc/rc.d/loki (917 bytes, patch)
2022-10-29 16:49 UTC, Yonas Yanfa
no flags Details | Diff
Improved syntax (917 bytes, patch)
2022-10-29 17:15 UTC, Yonas Yanfa
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yonas Yanfa 2022-10-29 16:49:55 UTC
Created attachment 237712 [details]
Diff to /usr/local/etc/rc.d/loki

By default, the log level is set to "info", which happens to be very verbose.

To avoid filling the log file and saving disk space, I recommend we set the default log level to "warn".

I've attached a patch to the rc.d script.
Comment 1 Yonas Yanfa 2022-10-29 17:15:30 UTC
Created attachment 237713 [details]
Improved syntax

Use `--log.level=${loki_loglevel}` instead of `--log.level ${loki_loglevel}`
Comment 2 Christopher Beppler 2022-10-29 18:55:47 UTC
Thank you for this.

I don't have commit rights, but the patch can (and should) be merged.
Comment 3 Nuno Teixeira freebsd_committer freebsd_triage 2022-10-29 21:59:57 UTC
There will be a bump PORTREVISION for this change.

Shouldn't a message be created so that end user knows about this change?

Something like:
---
{
type: upgrade
maximum_version: "2.6.1_6"
  message: <<EOM
Upgrading from before 2.6.1_6 log level default changed from "info" to "warn".
Configure ${ETCDIR}/rc.d/loki if needed to chance log level.
EOM
}
---

Cheers
Comment 4 commit-hook freebsd_committer freebsd_triage 2022-11-10 15:54:03 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=9e5e885d5a463a13f59d8d9743ad107a968376de

commit 9e5e885d5a463a13f59d8d9743ad107a968376de
Author:     Yonas Yanfa <yonas.yanfa@gmail.com>
AuthorDate: 2022-11-10 15:51:13 +0000
Commit:     Nuno Teixeira <eduardo@FreeBSD.org>
CommitDate: 2022-11-10 15:53:18 +0000

    sysutils/loki: Switch log level default from "info" to "warn"

    By default, the log level is set to "info", which happens to be very
    verbose.
    To avoid filling the log file and saving disk space, I recommend we set
    the default log level to "warn".

    PR:             267424

 sysutils/loki/Makefile      | 2 +-
 sysutils/loki/files/loki.in | 6 ++++++
 2 files changed, 7 insertions(+), 1 deletion(-)
Comment 5 Nuno Teixeira freebsd_committer freebsd_triage 2022-11-10 15:54:31 UTC
Committed, thanks!