Bug 267494 - multimedia/pipe-viewer: Update to 0.4.3
Summary: multimedia/pipe-viewer: Update to 0.4.3
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL: https://github.com/trizen/pipe-viewer...
Keywords:
Depends on: 267493
Blocks:
  Show dependency treegraph
 
Reported: 2022-11-01 14:51 UTC by Jesús Daniel Colmenares Oviedo
Modified: 2022-12-11 21:14 UTC (History)
1 user (show)

See Also:


Attachments
pipe-viewer-0.4.2.patch (2.17 KB, patch)
2022-11-01 14:51 UTC, Jesús Daniel Colmenares Oviedo
DtxdF: maintainer-approval+
Details | Diff
pipe-viewer-0.4.3.patch (2.61 KB, patch)
2022-11-23 02:17 UTC, Jesús Daniel Colmenares Oviedo
DtxdF: maintainer-approval+
Details | Diff
pipe-viewer-0.4.4.patch (2.59 KB, patch)
2022-12-06 23:07 UTC, Jesús Daniel Colmenares Oviedo
DtxdF: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jesús Daniel Colmenares Oviedo 2022-11-01 14:51:10 UTC
Created attachment 237784 [details]
pipe-viewer-0.4.2.patch

Description:

* Change p5-LWP-UserAgent-WithCache dependency to p5-LWP-UserAgent-Cached (*-Cached is the correct dependency)

ChangeLog: https://github.com/trizen/pipe-viewer/blob/0.4.2/Changes

* Support for `richItemRenderer` channel video results.
* GUI: allow the "next page" entry to be pressed multiple times (in case of network error).

QA:

* portlint:
  - WARN: Makefile: unless this is a master port, MAINTAINER has to be set by "=", not by "?=".
  - WARN: Makefile: unless this is a master port, COMMENT has to be set by "=", not by "?=".
* testport: (poudriere: 13.1-RELEASE, amd64, GTK3 JSON_XS LOCAL_CACHE READLINE SHARE_DIR CHAR_WIDTH LINE_BREAK YOUTUBE_DL YT_DLP tested):
  - Warning: devel/p5-Module-Build was in Perl CORE.  Check with `corelist Module::Build 0.4206` and `corelist -a Module::Build` if it should be conditionally added depending on PERL_LEVEL
  - Notice: You have some Perl modules as dependencies but you do not have devel/p5-Module-CoreList installed, the perlcore QA check gets better results when using it, especially with older Perl versions.
Comment 1 Jesús Daniel Colmenares Oviedo 2022-11-23 02:17:55 UTC
Created attachment 238270 [details]
pipe-viewer-0.4.3.patch

Description:

* Change p5-LWP-UserAgent-WithCache dependency to
  p5-LWP-UserAgent-Cached (*-Cached is the correct dependency).

ChangeLog: https://github.com/trizen/pipe-viewer/blob/0.4.3/Changes

* Added basic GET cache in `lwp_get()`.
* Fixed the support for popular videos from a channel.
* Fixed the extraction of the author name in `/browse` requests.
* Check search keywords for a playlist ID and for a channel ID.
* CLI: added the `:p=i` option for playlist results.
* GUI: added the `DEL` keybind in the "Saved channels" window to remove
  the selected channel.
* Extract livestream URL with the fallback method only when our code
  fails.
* Remember a working invidious instance and reuse it across multiple
  sessions for 1 hour.
* Memorize the output of yt-dlp/youtube-dl and reuse it.

QA (master - pipe-viewer):

* portlint:
  - FATAL: /usr/ports-devel/multimedia/pipe-viewer/pkg-plist: [35]: this port installs .desktop files. Please add `desktop-file-utils` to USES.
  - FATAL: /usr/ports-devel/multimedia/pipe-viewer/pkg-plist: [43]: this port installs .desktop files. Please add `desktop-file-utils` to USES.
  - WARN: Makefile: unless this is a master port, MAINTAINER has to be set by "=", not by "?=".
  - WARN: Makefile: unless this is a master port, COMMENT has to be set by "=", not by "?=".
* testport (poudriere: 13.1-RELEASE, amd64, JSON_XS LOCAL_CACHE READLINE LINE_BREAK YT_DLP tested):

QA (slave - gtk-pipe-viewer):

* portlint:
  - FATAL: Makefile: extra item "CONFLICTS_INSTALL" placed in the LICENSE section.
* testport (poudriere: 13.1-RELEASE, amd64, GTK JSON_XS LOCAL_CACHE READLINE SHARE_DIR LINE_BREAK YT_DLP tested):
  - Warning: you may not need USES=desktop-file-utils
  - Warning: devel/p5-Module-Build was in Perl CORE.  Check with `corelist Module::Build 0.4206` and `corelist -a Module::Build` if it should be conditionally added depending on PERL_LEVEL
  - Notice: You have some Perl modules as dependencies but you do not have devel/p5-Module-CoreList installed, the perlcore QA check gets better results when using it, especially with older Perl versions
Comment 2 Jesús Daniel Colmenares Oviedo 2022-12-06 23:07:28 UTC
Created attachment 238587 [details]
pipe-viewer-0.4.4.patch

Description:

* Change p5-LWP-UserAgent-WithCache dependency to
  p5-LWP-UserAgent-Cached (*-Cached is the correct dependency).

ChangeLog: https://github.com/trizen/pipe-viewer/blob/0.4.4/Changes

* CLI: added the `--shorts=s` and `--popular-shorts=s` command-line options.
* CLI: added the `:shorts=i` and `:popular-shorts=i` STDIN options.
* CLI: added the `--streams=s` and `--popular-streams=s` command-line options.
* CLI: added the `:streams=i` and `:popular-streams=i` STDIN options.
* CLI: added the `get_subscriptions_in_parallel` config-option (disabled by default)
* GUI: Added the `Author -> {Streams, Shorts, Popular streams}`.
* GUI: added the `Copy YouTube URL` right-click menu entry.
* Added support for the new format of YouTube usernames starting with `@`.

QA (master - pipe-viewer):

* portlint:
  - FATAL: /usr/ports-devel/multimedia/pipe-viewer/pkg-plist: [35]: this port installs .desktop files. Please add `desktop-file-utils` to USES.
  - FATAL: /usr/ports-devel/multimedia/pipe-viewer/pkg-plist: [43]: this port installs .desktop files. Please add `desktop-file-utils` to USES.
  - WARN: Makefile: unless this is a master port, MAINTAINER has to be set by "=", not by "?=".
  - WARN: Makefile: unless this is a master port, COMMENT has to be set by "=", not by "?=".
* testport (poudriere: 13.1-RELEASE, amd64, JSON_XS LOCAL_CACHE READLINE LINE_BREAK YT_DLP tested):
  - Warning: devel/p5-Module-Build was in Perl CORE.  Check with `corelist Module::Build 0.4206` and `corelist -a Module::Build` if it should be conditionally added depending on PERL_LEVEL
  - Notice: You have some Perl modules as dependencies but you do not have devel/p5-Module-CoreList installed, the perlcore QA check gets better results when using it, especially with older Perl versions.

QA (slave - gtk-pipe-viewer):

* portlint:
  - FATAL: Makefile: extra item "CONFLICTS_INSTALL" placed in the LICENSE section.
* testport (poudriere: 13.1-RELEASE, amd64, GTK JSON_XS LOCAL_CACHE READLINE SHARE_DIR LINE_BREAK YT_DLP tested):
  - Warning: you may not need USES=desktop-file-utils
  - Warning: devel/p5-Module-Build was in Perl CORE.  Check with `corelist Module::Build 0.4206` and `corelist -a Module::Build` if it should be conditionally added depending on PERL_LEVEL
  - Notice: You have some Perl modules as dependencies but you do not have devel/p5-Module-CoreList installed, the perlcore QA check gets better results when using it, especially with older Perl versions.

Notes:

* I think these errors, warnings and notices are false positives. I run in a clean environment (jail) and it works fine (pipe-viewer and gtk-pipe-viewer).
Comment 3 commit-hook freebsd_committer freebsd_triage 2022-12-11 21:06:24 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=94d5f0619385336c4f66d95f4fa95ad0a04aa719

commit 94d5f0619385336c4f66d95f4fa95ad0a04aa719
Author:     Jesús Daniel Colmenares Oviedo <DtxdF  at disroot.org>
AuthorDate: 2022-12-11 21:03:41 +0000
Commit:     Jose Alonso Cardenas Marquez <acm@FreeBSD.org>
CommitDate: 2022-12-11 21:03:41 +0000

    multimedia/pipe-viewer: Update to 0.4.4

    * Change p5-LWP-UserAgent-WithCache dependency to
      p5-LWP-UserAgent-Cached (*-Cached is the correct dependency).

    ChangeLog at:   https://github.com/trizen/pipe-viewer/blob/0.4.4/Changes
    PR:             267494

 multimedia/pipe-viewer/Makefile | 4 ++--
 multimedia/pipe-viewer/distinfo | 6 +++---
 2 files changed, 5 insertions(+), 5 deletions(-)
Comment 4 Jose Alonso Cardenas Marquez freebsd_committer freebsd_triage 2022-12-11 21:14:15 UTC
Committed thanks!