Bug 267594 - net/traff: fix build with -fno-common
Summary: net/traff: fix build with -fno-common
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Fernando Apesteguía
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-11-06 12:56 UTC by Robert Clausecker
Modified: 2022-11-17 07:08 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (daniel)
fernape: merge-quarterly+

Attachments
net/traff: fix build with -fno-common (2.45 KB, patch)
2022-11-06 12:56 UTC, Robert Clausecker 		fuz: maintainer-approval? (daniel)
 Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Clausecker freebsd_committer freebsd_triage 2022-11-06 12:56:46 UTC 
Created attachment 237894 [details]
net/traff: fix build with -fno-common

While we are at it:

 - define LICENSE
 - fix missing LIB_DEPENDS on libargp.so

Tested with Poudriere on armv7 arm64 FreeBSD 13.1.
Please MFH if possible.
Comment 1 commit-hook freebsd_committer freebsd_triage 2022-11-17 07:08:22 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=98a1bc7f0d2f5539100fe22e27f83cedb29ab040

commit 98a1bc7f0d2f5539100fe22e27f83cedb29ab040
Author:     Robert Clausecker <fuz@fuz.su>
AuthorDate: 2022-11-07 19:08:14 +0000
Commit:     Fernando Apesteguía <fernape@FreeBSD.org>
CommitDate: 2022-11-17 07:03:33 +0000

    net/traff: fix build with -fno-common

    Also:

     * define LICENSE
     * fix missing LIB_DEPENDS on libargp.so

    PR:             267594
    Reported by:    fuz@fuz.su
    Approved by:    daniel@freebsd.ro (maintainer, timeout 2 weeks)
    MFH:            2022Q4 (build fix)

 net/traff/Makefile                       |  9 +++++----
 net/traff/files/patch-readconfig.c (new) | 11 +++++++++++
 net/traff/files/patch-readconfig.h       | 12 ++++++++++--
 3 files changed, 26 insertions(+), 6 deletions(-)
Comment 2 commit-hook freebsd_committer freebsd_triage 2022-11-17 07:08:23 UTC 
A commit in branch 2022Q4 references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=0330fdec13705154dfffcbd8cfa0cf8760699353

commit 0330fdec13705154dfffcbd8cfa0cf8760699353
Author:     Robert Clausecker <fuz@fuz.su>
AuthorDate: 2022-11-07 19:08:14 +0000
Commit:     Fernando Apesteguía <fernape@FreeBSD.org>
CommitDate: 2022-11-17 07:04:18 +0000

    net/traff: fix build with -fno-common

    Also:

     * define LICENSE
     * fix missing LIB_DEPENDS on libargp.so

    PR:             267594
    Reported by:    fuz@fuz.su
    Approved by:    daniel@freebsd.ro (maintainer, timeout 2 weeks)
    MFH:            2022Q4 (build fix)

    (cherry picked from commit 98a1bc7f0d2f5539100fe22e27f83cedb29ab040)

 net/traff/Makefile                       |  9 +++++----
 net/traff/files/patch-readconfig.c (new) | 11 +++++++++++
 net/traff/files/patch-readconfig.h       | 12 ++++++++++--
 3 files changed, 26 insertions(+), 6 deletions(-)
Comment 3 Fernando Apesteguía freebsd_committer freebsd_triage 2022-11-17 07:08:33 UTC 
Committed and merged to 2022Q4,

Thanks!